Refactored config system again

common/config.go

@@ -36,30 +36,6 @@ type Cloudflare struct {
 	CFAPIKey string `mapstructure:"cf_api_key" toml:"cf_api_key"`
 }
 
-type DomainConfig struct {
-	Domain       DomainCfg   `mapstructure:"domain" toml:"domain"`
-	Certificates DomainCerts `mapstructure:"certificates" toml:"certificates"`
-	Repo         Repo        `mapstructure:"repo" toml:"repo"`
-	Internal     Internal    `mapstructure:"shared" toml:"shared"`
-}
-
-type DomainCfg struct {
-	DomainName string `mapstructure:"domain_name" toml:"domain_name"`
-	Enabled    bool   `mapstructure:"enabled" toml:"enabled"`
-	DNSServer  string `mapstructure:"dns_server" toml:"dns_server"`
-}
-
-type DomainCerts struct {
-	DataRoot      string   `mapstructure:"data_root" toml:"data_root"`
-	RequestMethod string   `mapstructure:"request_method" toml:"request_method"`
-	CryptoKey     string   `mapstructure:"crypto_key" toml:"crypto_key"`
-	Expiry        int      `mapstructure:"expiry" toml:"expiry"`
-	RenewPeriod   int      `mapstructure:"renew_period" toml:"renew_period"`
-	SubDomains    []string `mapstructure:"sub_domains" toml:"sub_domains"`
-	CertSymlinks  []string `mapstructure:"cert_symlinks" toml:"cert_symlinks"`
-	KeySymlinks   []string `mapstructure:"key_symlinks" toml:"key_symlinks"`
-}
-
 type Repo struct {
 	RepoSuffix string `mapstructure:"repo_suffix" toml:"repo_suffix"`
 }
@@ -69,3 +45,51 @@ type Internal struct {
 	RepoExists bool   `mapstructure:"repo_exists" toml:"repo_exists"`
 	Status     string `mapstructure:"status" toml:"status"`
 }
+
+// ---------------------------------------------------------------------------
+//  Server domain config
+// ---------------------------------------------------------------------------
+
+type ServerDomainConfig struct {
+	Domain       ServerDomainCfg   `mapstructure:"domain" toml:"domain"`
+	Certificates ServerDomainCerts `mapstructure:"certificates" toml:"certificates"`
+	Repo         Repo              `mapstructure:"repo" toml:"repo"`
+	Internal     Internal          `mapstructure:"internal" toml:"internal"`
+}
+
+type ServerDomainCfg struct {
+	DomainName string `mapstructure:"domain_name" toml:"domain_name"`
+	Enabled    bool   `mapstructure:"enabled" toml:"enabled"`
+	DNSServer  string `mapstructure:"dns_server" toml:"dns_server"`
+}
+
+type ServerDomainCerts struct {
+	DataRoot      string   `mapstructure:"data_root" toml:"data_root"`
+	CryptoKey     string   `mapstructure:"crypto_key" toml:"crypto_key"`
+	RequestMethod string   `mapstructure:"request_method" toml:"request_method"`
+	Expiry        int      `mapstructure:"expiry" toml:"expiry"`
+	RenewPeriod   int      `mapstructure:"renew_period" toml:"renew_period"`
+	SubDomains    []string `mapstructure:"sub_domains" toml:"sub_domains"`
+}
+
+// ---------------------------------------------------------------------------
+//  Client domain config
+// ---------------------------------------------------------------------------
+
+type ClientDomainConfig struct {
+	Domain       ClientDomainCfg   `mapstructure:"domain" toml:"domain"`
+	Certificates ClientDomainCerts `mapstructure:"certificates" toml:"certificates"`
+	Repo         Repo              `mapstructure:"repo" toml:"repo"`
+}
+
+type ClientDomainCfg struct {
+	DomainName string `mapstructure:"domain_name" toml:"domain_name"`
+	Enabled    bool   `mapstructure:"enabled" toml:"enabled"`
+}
+
+type ClientDomainCerts struct {
+	DataRoot     string   `mapstructure:"data_root" toml:"data_root"`
+	CryptoKey    string   `mapstructure:"crypto_key" toml:"crypto_key"`
+	CertSymlinks []string `mapstructure:"cert_symlinks" toml:"cert_symlinks"`
+	KeySymlinks  []string `mapstructure:"key_symlinks" toml:"key_symlinks"`
+}

common/git.go

@@ -96,7 +96,7 @@ func CreateGiteaClient(config *AppConfig) *gitea.Client {
 //	return *repo.CloneURL
 //}
 
-func CreateGiteaRepo(domain string, giteaClient *gitea.Client, config *AppConfig, domainConfig *DomainConfig) string {
+func CreateGiteaRepo(domain string, giteaClient *gitea.Client, config *AppConfig, domainConfig *ServerDomainConfig) string {
 	options := gitea.CreateRepoOption{
 		Name:          domain + domainConfig.Repo.RepoSuffix,
 		Description:   "Certificate storage for " + domain,

common/util.go

@@ -293,15 +293,15 @@ func MakeCredential(username, groupname string) (*syscall.Credential, error) {
 	return &syscall.Credential{Uid: uid, Gid: gid}, nil
 }
 
-func EffectiveDataRoot(config *AppConfig, domainConfig *DomainConfig) string {
+// EffectiveDataRoot resolves the data root for a domain. The per-domain
+// override takes precedence; otherwise the app-level data root is used; if
+// both are empty, the current working directory is used.
+func EffectiveDataRoot(config *AppConfig, domainDataRoot string) string {
 	if config == nil {
 		return ""
 	}
-	if domainConfig == nil {
-		return ""
-	}
 
-	if domainConfig.Certificates.DataRoot == "" {
+	if domainDataRoot == "" {
 		if config.Certificates.DataRoot == "" {
 			workDir, err := os.Getwd()
 			if err != nil {
@@ -311,7 +311,7 @@ func EffectiveDataRoot(config *AppConfig, domainConfig *DomainConfig) string {
 		}
 		return config.Certificates.DataRoot
 	}
-	return domainConfig.Certificates.DataRoot
+	return domainDataRoot
 }
 
 var fqdnRegex = regexp.MustCompile(`^(?i:[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.)+[a-z]{2,}$`)