Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Update yarn, loader and api #31

Merged
13rac1 merged 2 commits from bump-deps into master 2019-11-19 22:38:13 +00:00
Conversation 22 Commits 2 Files Changed 3 +7 -6
13rac1 commented 2019-11-14 03:17:16 +00:00 (Migrated from github.com)
Copy Link

Significant version bumps since August. I figure this should be updated.

Significant version bumps since August. I figure this should be updated.
liach commented 2019-11-14 03:25:15 +00:00 (Migrated from github.com)
Copy Link

Uh, we actually have a toolchain update and this pr may need to adjust accordingly.

Uh, we actually have a toolchain update and this pr may need to adjust accordingly.
13rac1 commented 2019-11-14 04:16:03 +00:00 (Migrated from github.com)
Copy Link

Oh? This configuration builds and runs as-is. Perhaps no other updates are needed yet?

$ ./gradlew build

> Configure project :
Fabric Loom: 0.2.5-SNAPSHOT Build(jenkins #21)
:setting up loom dependencies
:setting up mappings (yarn 1.14.4+build.14)
:providing net.fabricmc.fabric-api:fabric-api:0.4.1+build.245-1.14 (net.fabricmc.yarn.1_14_4.14)
:remapping fabric-api-0.4.1+build.245-1.14.jar (TinyRemapper, intermediary -> named)
<snip>
:providing net.fabricmc:fabric-loader:0.6.4+build.169 (net.fabricmc.yarn.1_14_4.14)
:remapping fabric-loader-0.6.4+build.169.jar (TinyRemapper, intermediary -> named)
sources
:loading intermediary -> named source mappings
<snip>
> Task :compileJava
:setting java compiler args
Could not find refmap definition, will be using default name: fabric-example-mod-refmap.json
Note: SpongePowered MIXIN Annotation Processor Version=0.7.11
Note: ObfuscationServiceFabric supports type: "official:intermediary"
Note: ObfuscationServiceFabric supports type: "official:named"
Note: ObfuscationServiceFabric supports type: "intermediary:official"
Note: ObfuscationServiceFabric supports type: "intermediary:named"
Note: ObfuscationServiceFabric supports type: "named:official"
Note: ObfuscationServiceFabric supports type: "named:intermediary"
Note: ObfuscationServiceMCP supports type: "searge"
Note: ObfuscationServiceMCP supports type: "notch"
<snip>

> Task :remapJar
:remapping fabric-example-mod-1.0.0-dev.jar
mixin-map-1.14.4-14.tiny: 4976 classes, 21969 methods, 18195 fields

> Task :remapSourcesJar
:loading named -> intermediary source mappings
:remapping source jar

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 32s
6 actionable tasks: 4 executed, 2 up-to-date
Oh? This configuration builds and runs as-is. Perhaps no other updates are needed yet? ``` $ ./gradlew build > Configure project : Fabric Loom: 0.2.5-SNAPSHOT Build(jenkins #21) :setting up loom dependencies :setting up mappings (yarn 1.14.4+build.14) :providing net.fabricmc.fabric-api:fabric-api:0.4.1+build.245-1.14 (net.fabricmc.yarn.1_14_4.14) :remapping fabric-api-0.4.1+build.245-1.14.jar (TinyRemapper, intermediary -> named) <snip> :providing net.fabricmc:fabric-loader:0.6.4+build.169 (net.fabricmc.yarn.1_14_4.14) :remapping fabric-loader-0.6.4+build.169.jar (TinyRemapper, intermediary -> named) sources :loading intermediary -> named source mappings <snip> > Task :compileJava :setting java compiler args Could not find refmap definition, will be using default name: fabric-example-mod-refmap.json Note: SpongePowered MIXIN Annotation Processor Version=0.7.11 Note: ObfuscationServiceFabric supports type: "official:intermediary" Note: ObfuscationServiceFabric supports type: "official:named" Note: ObfuscationServiceFabric supports type: "intermediary:official" Note: ObfuscationServiceFabric supports type: "intermediary:named" Note: ObfuscationServiceFabric supports type: "named:official" Note: ObfuscationServiceFabric supports type: "named:intermediary" Note: ObfuscationServiceMCP supports type: "searge" Note: ObfuscationServiceMCP supports type: "notch" <snip> > Task :remapJar :remapping fabric-example-mod-1.0.0-dev.jar mixin-map-1.14.4-14.tiny: 4976 classes, 21969 methods, 18195 fields > Task :remapSourcesJar :loading named -> intermediary source mappings :remapping source jar Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/5.5.1/userguide/command_line_interface.html#sec:command_line_warnings BUILD SUCCESSFUL in 32s 6 actionable tasks: 4 executed, 2 up-to-date ```
natanfudge commented 2019-11-14 09:13:28 +00:00 (Migrated from github.com)
Copy Link

Modmuss backported the parser fix to 0.2.5 so this should be ok

Modmuss backported the parser fix to 0.2.5 so this should be ok
liach commented 2019-11-14 09:14:10 +00:00 (Migrated from github.com)
Copy Link

We should just use v2 mappings in the example mod, so need an update to build.gradle

We should just use v2 mappings in the example mod, so need an update to build.gradle
13rac1 commented 2019-11-14 19:31:01 +00:00 (Migrated from github.com)
Copy Link

I'm not 100% on what you'd like me to change. Do you mean the loom version?

diff --git a/build.gradle b/build.gradle
index 8542e88..46a0735 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,5 +1,5 @@
 plugins {
-       id 'fabric-loom' version '0.2.5-SNAPSHOT'
+       id 'fabric-loom' version '0.2.6-SNAPSHOT'
        id 'maven-publish'
 }

On my Ubuntu 18.04:

$ java --version
openjdk 11.0.4 2019-07-16
OpenJDK Runtime Environment (build 11.0.4+11-post-Ubuntu-1ubuntu218.04.3)
OpenJDK 64-Bit Server VM (build 11.0.4+11-post-Ubuntu-1ubuntu218.04.3, mixed mode, sharing)

0.2.5 - Works fine.

[11:21:20] [main/INFO]: LWJGL Version: 3.2.2 build 10

0.2.6 - Crashes Failed to locate library: liblwjgl.so:

[11:22:14] [main/INFO]: [STDERR]: [LWJGL] Failed to load a library. Possible solutions:
<snip>
I'm not 100% on what you'd like me to change. Do you mean the loom version? ```diff diff --git a/build.gradle b/build.gradle index 8542e88..46a0735 100644 --- a/build.gradle +++ b/build.gradle @@ -1,5 +1,5 @@ plugins { - id 'fabric-loom' version '0.2.5-SNAPSHOT' + id 'fabric-loom' version '0.2.6-SNAPSHOT' id 'maven-publish' } ``` On my Ubuntu 18.04: ```bash $ java --version openjdk 11.0.4 2019-07-16 OpenJDK Runtime Environment (build 11.0.4+11-post-Ubuntu-1ubuntu218.04.3) OpenJDK 64-Bit Server VM (build 11.0.4+11-post-Ubuntu-1ubuntu218.04.3, mixed mode, sharing) ``` **0.2.5** - Works fine. ``` [11:21:20] [main/INFO]: LWJGL Version: 3.2.2 build 10 ``` **0.2.6** - Crashes `Failed to locate library: liblwjgl.so`: ``` [11:22:14] [main/INFO]: [STDERR]: [LWJGL] Failed to load a library. Possible solutions: <snip> ```
modmuss50 commented 2019-11-14 19:33:20 +00:00 (Migrated from github.com)
Copy Link

Humm, 0.2.6 should work just fine? What IDE are you using to run the game? if its vscode or eclipse you need to re-run the setup tasks. For now its still classed as experimetal and there will be a full upgrade guide covering this once im sure its stable enough to be used by the masses.

I did plan on doing the full update to v2 mappings in one commit to this repo to show users how to do it along with the versions.

Humm, 0.2.6 should work just fine? What IDE are you using to run the game? if its vscode or eclipse you need to re-run the setup tasks. For now its still classed as experimetal and there will be a full upgrade guide covering this once im sure its stable enough to be used by the masses. I did plan on doing the full update to v2 mappings in one commit to this repo to show users how to do it along with the versions.
👍 1
13rac1 commented 2019-11-14 20:10:37 +00:00 (Migrated from github.com)
Copy Link

I use vscode, but this runtime failure occurs IDE-less in the CLI. I've recloned, changed the 5 to 6, run the build/client, and gotten the same issue multiple times:

$ git clone https://github.com/13rac1/fabric-example-mod.git
$ cd fabric-example-mod
$ git checkout bump-deps
$ vi build.gradle
$ ./gradlew runClient

Crash log: crash-2019-11-14_11.42.01-client.txt

I've reproduced within Docker. The runClient task crashes with the same error conveniently before attempting to open a Window.

docker run -it --rm openjdk:11-stretch bash

I was hoping to just bump the other versions in this PR. Seems best to hold off on the v2 mappings for now? Feel free to just close this PR if you want to handle it later. Thanks!

I use vscode, but this runtime failure occurs IDE-less in the CLI. I've recloned, changed the `5` to `6`, run the build/client, and gotten the same issue multiple times: ```bash $ git clone https://github.com/13rac1/fabric-example-mod.git $ cd fabric-example-mod $ git checkout bump-deps $ vi build.gradle $ ./gradlew runClient ``` Crash log: [crash-2019-11-14_11.42.01-client.txt](https://github.com/FabricMC/fabric-example-mod/files/3848377/crash-2019-11-14_11.42.01-client.txt) I've reproduced within Docker. The `runClient` task crashes with the same error conveniently before attempting to open a Window. ``` docker run -it --rm openjdk:11-stretch bash ``` I was hoping to just bump the other versions in this PR. Seems best to hold off on the v2 mappings for now? Feel free to just close this PR if you want to handle it later. Thanks!
modmuss50 commented 2019-11-14 20:12:31 +00:00 (Migrated from github.com)
Copy Link

What are the contents of <project-dir>/.gradle/loom-cache/launch.cfg? after running the runClient command?

What are the contents of `<project-dir>/.gradle/loom-cache/launch.cfg`? after running the runClient command?
13rac1 commented 2019-11-14 22:07:34 +00:00 (Migrated from github.com)
Copy Link
$ cat .gradle/loom-cache/launch.cfg
commonProperties
        fabric.development=true
clientArgs
        --assetIndex
        1.14.4-1.14
        --assetsDir
        /root/.gradle/caches/fabric-loom/assets
clientProperties
        java.library.path=/root/.gradle/caches/fabric-loom/natives/1.14.4
        org.lwjgl.librarypath=/root/.gradle/caches/fabric-loom/natives/1.14.4

Complete log of a run within Docker: docker-openjdk11-fabric-loom-0.2.6.log Steps to reproduce:

docker run -it --rm openjdk:11-stretch bash
git clone https://github.com/13rac1/fabric-example-mod.git
cd fabric-example-mod
git checkout bump-deps-loom-0.2.6
./gradlew runClient

Note: 0.2.5 also crashes within Docker, because there's no display. That is expected though. The error message is different.

```bash $ cat .gradle/loom-cache/launch.cfg commonProperties fabric.development=true clientArgs --assetIndex 1.14.4-1.14 --assetsDir /root/.gradle/caches/fabric-loom/assets clientProperties java.library.path=/root/.gradle/caches/fabric-loom/natives/1.14.4 org.lwjgl.librarypath=/root/.gradle/caches/fabric-loom/natives/1.14.4 ``` Complete log of a run within Docker: [docker-openjdk11-fabric-loom-0.2.6.log](https://github.com/FabricMC/fabric-example-mod/files/3848827/docker-openjdk11-fabric-loom-0.2.6.log) Steps to reproduce: ```bash docker run -it --rm openjdk:11-stretch bash git clone https://github.com/13rac1/fabric-example-mod.git cd fabric-example-mod git checkout bump-deps-loom-0.2.6 ./gradlew runClient ``` Note: 0.2.5 also crashes within Docker, because there's no display. That is expected though. The error message is different.
modmuss50 commented 2019-11-14 22:23:37 +00:00 (Migrated from github.com)
Copy Link

Humm yeah, reproduced in docker. Need to fix this before 0.2.6 becomes the main version.

Humm yeah, reproduced in docker. Need to fix this before 0.2.6 becomes the main version.
modmuss50 commented 2019-11-14 22:31:52 +00:00 (Migrated from github.com)
Copy Link

And can reproduce on MacOS

And can reproduce on MacOS
modmuss50 commented 2019-11-15 09:16:20 +00:00 (Migrated from github.com)
Copy Link

Can you try again now please? Seems to have fixed it on mac os

Can you try again now please? Seems to have fixed it on mac os
13rac1 commented 2019-11-15 18:42:54 +00:00 (Migrated from github.com)
Copy Link

Works!

It's working in Docker (AKA crashing as expected) with the new snapshot. Was Fabric Loom: 0.2.6-SNAPSHOT Build(jenkins #19), now Fabric Loom: 0.2.6-SNAPSHOT Build(jenkins #20). Locally, I had to manually remove the loom jars, since these snapshots don't have version numbers. Used find ~/.gradle/ -name "*fabric-loom*" | xargs rm -rf because I didn't want to clear my entire gradle cache. Should/can Loom build versions be added?

Works! It's working in Docker (AKA crashing as expected) with the new snapshot. Was `Fabric Loom: 0.2.6-SNAPSHOT Build(jenkins #19)`, now `Fabric Loom: 0.2.6-SNAPSHOT Build(jenkins #20)`. Locally, I had to manually remove the loom jars, since these snapshots don't have version numbers. Used `find ~/.gradle/ -name "*fabric-loom*" | xargs rm -rf` because I didn't want to clear my entire gradle cache. Should/can Loom build versions be added?
liach commented 2019-11-15 20:08:18 +00:00 (Migrated from github.com)
Copy Link

please include the build.gradle loom change since loom 0.2.6 works. also another part of build.gradle will need an update

please include the build.gradle loom change since loom 0.2.6 works. also another part of build.gradle will need an update
natanfudge commented 2019-11-15 20:12:38 +00:00 (Migrated from github.com)
Copy Link

I would rather know https://github.com/FabricMC/fabric-loom/pull/141 and https://github.com/FabricMC/fabric-loom/pull/145 are OK first.

I would rather know https://github.com/FabricMC/fabric-loom/pull/141 and https://github.com/FabricMC/fabric-loom/pull/145 are OK first.
13rac1 commented 2019-11-15 22:07:05 +00:00 (Migrated from github.com)
Copy Link

@liach 😆 I forgot the git add, before the amend. Fixed. What else needs to be changed?

@liach :laughing: I forgot the `git add`, before the amend. Fixed. What else needs to be changed?
modmuss50 commented 2019-11-19 20:32:03 +00:00 (Migrated from github.com)
Copy Link

There is a new loader update, and move to v2 mappings then im happy with this.

There is a new loader update, and move to v2 mappings then im happy with this.
👍 1
13rac1 commented 2019-11-19 22:22:58 +00:00 (Migrated from github.com)
Copy Link

I've updated to the versions listed on https://modmuss50.me/fabric.html?&version=1.14.4 runClient works as expected. I'm not sure this means I've set the "v2 mappings" though, because I cannot find documentation explaining the difference and internet searches lead me back to this PR. 😆

I've updated to the versions listed on https://modmuss50.me/fabric.html?&version=1.14.4 `runClient` works as expected. I'm not sure this means I've set the "v2 mappings" though, because I cannot find documentation explaining the difference and internet searches lead me back to this PR. :laughing:
modmuss50 commented 2019-11-19 22:29:53 +00:00 (Migrated from github.com)
Copy Link

Pushed V2 and a small tweak to the mod.json to your fork.

This should be good to be merged now.

Pushed V2 and a small tweak to the mod.json to your fork. This should be good to be merged now.
👍 1
sfPlayer1 (Migrated from github.com) approved these changes 2019-11-19 22:37:07 +00:00
liach (Migrated from github.com) approved these changes 2019-11-19 22:37:24 +00:00
natanfudge commented 2019-11-20 05:46:38 +00:00 (Migrated from github.com)
Copy Link

@13rac1, the best way to stay up to date is joining the discord https://discord.gg/v6v4pMv

@13rac1, the best way to stay up to date is joining the discord https://discord.gg/v6v4pMv
13rac1 commented 2019-11-20 22:18:44 +00:00 (Migrated from github.com)
Copy Link

@natanfudge Ah ha! Thanks! We need to post elsewhere too, since information on Discord will not necessarily be available in the future. Should the Fabric Latest Versions website be updated too?

@natanfudge Ah ha! Thanks! We need to post elsewhere too, since information on Discord will not necessarily be available in the future. Should the _Fabric Latest Versions_ website be updated too?
modmuss50 commented 2019-11-20 22:21:37 +00:00 (Migrated from github.com)
Copy Link

Yes, I need to do that.

Yes, I need to do that.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
sfPlayer1
liach
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#31
No description provided.
Delete Branch "bump-deps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?