Add minVersion to template mixin config #41

2020-02-23T23:12:33Z

i509VCB commented

2020-02-23 23:12:33 +00:00

(Migrated from github.com)

As per a discussion on Spongecord with Mumfrey he noticed the obvious lack of a minVersion element within the Mixin config included in the template mod and reccomended the addition of one. Of course since loader 0.7+ uses mixin 0.8, the default minVersion is set to 0.8

As per a discussion on Spongecord with Mumfrey he noticed the obvious lack of a `minVersion` element within the Mixin config included in the template mod and reccomended the addition of one. Of course since loader 0.7+ uses mixin 0.8, the default `minVersion` is set to `0.8`

modmuss50 commented

2020-02-24 00:08:24 +00:00

(Migrated from github.com)

I don’t think this is needed, loader gets a version bump when mixin gets updated, so if you need to depend on a mixin version I’d just depend on the loader version. You get an error gui as well.

👍 3

UpcraftLP (Migrated from github.com) approved these changes 2020-02-24 10:25:48 +00:00

UpcraftLP commented

2020-02-24 10:29:07 +00:00

(Migrated from github.com)

I don’t think this is needed, loader gets a version bump when mixin gets updated, so if you need to depend on a mixin version I’d just depend on the loader version. You get an error gui as well.

still, it'd be good practice to have a minVersion specified and thus have mixin show a proper error, rather than just failing for missing classes/methods.

> I don’t think this is needed, loader gets a version bump when mixin gets updated, so if you need to depend on a mixin version I’d just depend on the loader version. You get an error gui as well. still, it'd be good practice to have a `minVersion` specified and thus have mixin show a proper error, rather than just failing for missing classes/methods.

sfPlayer1 commented

2020-02-24 10:52:57 +00:00

(Migrated from github.com)

I think the change is not bad, but it definitely shouldn't go in without also bumping the loader dep to at least .4

i509VCB commented

2020-02-24 13:11:20 +00:00

(Migrated from github.com)

I will do that a bit later today

i509VCB commented

2020-02-24 15:35:25 +00:00

(Migrated from github.com)

Since we are at this, I've thought of possibly changing a bit with properties version to remove the redundant yarn MC version and makes it something like this in the mappings:
https://github.com/i509VCB/BulkyShulkies/blob/1.15.x/build.gradle#L63

That specifically doesn't need to be included but I feel it simplifies the setup

Since we are at this, I've thought of possibly changing a bit with properties version to remove the redundant yarn MC version and makes it something like this in the mappings: https://github.com/i509VCB/BulkyShulkies/blob/1.15.x/build.gradle#L63 That specifically doesn't need to be included but I feel it simplifies the setup

liach commented

2020-02-24 15:49:49 +00:00

(Migrated from github.com)

I recall the fabric loom automatically adds this attribute to mixin jsons when building the mod

i509VCB commented

2020-02-24 16:08:38 +00:00

(Migrated from github.com)

Hmm I extracted bulky shulkies (release 1.0.5 and I didn't see the minVersion set at all by Loom)

👀 1

i509VCB commented

2020-02-24 21:50:32 +00:00

(Migrated from github.com)