Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Example build.gradle uses snapshot version of loom #48

New Issue
Open
opened 2020-04-17 12:13:15 +00:00 by immibis · 6 comments
immibis commented 2020-04-17 12:13:15 +00:00 (Migrated from github.com)
Copy Link

The example mod's build.gradle has:

id 'fabric-loom' version '0.2.7-SNAPSHOT'

This seems bad - snapshot versions of Loom should only be used for Loom development.

The example mod's build.gradle has: ``` id 'fabric-loom' version '0.2.7-SNAPSHOT' ``` This seems bad - snapshot versions of Loom should only be used for Loom development.
shedaniel commented 2020-04-17 12:21:06 +00:00 (Migrated from github.com)
Copy Link

There isn't a loom version that is not a snapshot

There isn't a loom version that is not a snapshot
👍 6
immibis commented 2020-04-17 12:23:52 +00:00 (Migrated from github.com)
Copy Link

Then maybe this should be a Loom bug instead.

Then maybe this should be a Loom bug instead.
shedaniel commented 2020-04-17 12:27:35 +00:00 (Migrated from github.com)
Copy Link

I wouldn't say this is a "bug", but potentially a "small issue"?

I wouldn't say this is a "bug", but potentially a "small issue"?
Prospector commented 2020-04-17 12:28:13 +00:00 (Migrated from github.com)
Copy Link

it's the current intended way for it to work, though it could be argued that it's not a great way.

it's the current intended way for it to work, though it could be argued that it's not a great way.
👍 5
immibis commented 2020-04-17 12:29:14 +00:00 (Migrated from github.com)
Copy Link

Potentially having a different version every time you ask for the same version seems like a bug to me. You build your mod and it works, someone else clones your mod and builds it, and it doesn't work for them because something changed in Loom, even though they have the same Loom version.

Potentially having a different version every time you ask for the same version seems like a bug to me. You build your mod and it works, someone else clones your mod and builds it, and it doesn't work for them because something changed in Loom, even though they have the same Loom version.
liach commented 2020-04-17 21:23:36 +00:00 (Migrated from github.com)
Copy Link

Currently loom 0.2.6 has a few problems and 0.2.7 fixes most of those. 0.2.7 isn't unstable.

Currently loom 0.2.6 has a few problems and 0.2.7 fixes most of those. 0.2.7 isn't unstable.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Steven
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#48
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?