Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Remove Fabric API dependencies #55

New Issue
Open
opened 2020-05-29 20:17:37 +00:00 by kvverti · 3 comments
kvverti commented 2020-05-29 20:17:37 +00:00 (Migrated from github.com)
Copy Link

Remove the modImplementation of the full fabric API, and remove "fabric": "*" from the example mod's fabric.mod.json.

Leaving the fabric API in the example mod means that many mods depend on the full Fabric API, even when they don't use all of API's modules.

This issue is part of a plan to improve depending on Fabric API.

Remove the `modImplementation` of the full fabric API, and remove `"fabric": "*"` from the example mod's `fabric.mod.json`. Leaving the fabric API in the example mod means that many mods depend on the full Fabric API, even when they don't use all of API's modules. This issue is part of [a plan to improve depending on Fabric API](https://gist.github.com/kvverti/3fc6a05d974210f785a9a751d5e0ae28).
👎 2
Pyrofab commented 2020-05-29 21:25:59 +00:00 (Migrated from github.com)
Copy Link

I think one possibility would be to add commented out dependencies on every existing API module. That way, enabling modules just takes a few keystrokes, and discoverability stays high.

I think one possibility would be to add commented out dependencies on every existing API module. That way, enabling modules just takes a few keystrokes, and discoverability stays high.
👍 1
i509VCB commented 2020-05-29 21:38:27 +00:00 (Migrated from github.com)
Copy Link

Until a solution is written up and accepted, I would say no.

Until a solution is written up and accepted, I would say no.
eehunter commented 2021-06-28 18:32:34 +00:00 (Migrated from github.com)
Copy Link

@Pyrofab JSON doesn't allow comments.

@Pyrofab JSON doesn't allow comments.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Steven
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#55
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?