gradle configuration update #7

2019-02-15T21:01:37Z

UpcraftLP commented

2019-02-15 21:01:37 +00:00

(Migrated from github.com)

moved version variables to gradle.properties file
use constants for the compatibility levels
add a default configuration for the maven-publish plugin
fix character encoding in some edge cases where UTF-8 is not the system default charset
add javadoc task

- moved version variables to gradle.properties file - use constants for the compatibility levels - add a default configuration for the maven-publish plugin - fix character encoding in some edge cases where UTF-8 is not the system default charset - add javadoc task

modmuss50 (Migrated from github.com) requested changes 2019-02-15 21:04:05 +00:00

build.gradle

modmuss50 (Migrated from github.com) commented

2019-02-15 21:03:34 +00:00

Bad indentation

build.gradle

modmuss50 (Migrated from github.com) commented

2019-02-15 21:03:55 +00:00

Do we really need a javadoc?

UpcraftLP (Migrated from github.com) reviewed 2019-02-15 21:04:43 +00:00

build.gradle

						
				@ -21,0 +32,4 @@

						include "fabric.mod.json"

						// add mod metadata

						expand "version": project.version

UpcraftLP (Migrated from github.com) commented

2019-02-15 21:04:43 +00:00

well I thought it'd be a nice-to-have, mainly for including it in the maven publication

modmuss50 (Migrated from github.com) reviewed 2019-02-15 21:31:44 +00:00

build.gradle

						
				@ -21,0 +32,4 @@

						include "fabric.mod.json"

						// add mod metadata

						expand "version": project.version

modmuss50 (Migrated from github.com) commented

2019-02-15 21:31:44 +00:00

It adds quite a bit more to the build.gradle (due to the fix bellow). And there are source jars anyway so when you depend on a mod it should give you sources.

modmuss50 commented

2019-02-15 21:33:45 +00:00

(Migrated from github.com)

Another thing I did want to include in the example mod was auto setting the version number in the fabric.mod.json file.

This can be done like so:

processResources {
  from(sourceSets.main.resources.srcDirs) {
    include 'fabric.mod.json'
    expand version: project.version
  }
  from(sourceSets.main.resources.srcDirs) {
    exclude 'fabric.mod.json'
  }
}

{
  "id": "modid",
  "name": "Example mod",
  "version": "$version"
}

Not a critical thing to get in, would be nice though.

Another thing I did want to include in the example mod was auto setting the version number in the fabric.mod.json file. This can be done like so: ```groovy processResources { from(sourceSets.main.resources.srcDirs) { include 'fabric.mod.json' expand version: project.version } from(sourceSets.main.resources.srcDirs) { exclude 'fabric.mod.json' } } ``` ```json { "id": "modid", "name": "Example mod", "version": "$version" } ``` Not a critical thing to get in, would be nice though.

UpcraftLP commented

2019-02-15 21:34:54 +00:00

(Migrated from github.com)

Another thing I did want to include in the example mod was auto setting the version number in the fabric.mod.json file.

Pretty much what I do in all of my mods anyways, sure, will add it

>Another thing I did want to include in the example mod was auto setting the version number in the fabric.mod.json file. Pretty much what I do in all of my mods anyways, sure, will add it

modmuss50 (Migrated from github.com) approved these changes 2019-02-15 21:45:43 +00:00

modmuss50 (Migrated from github.com) left a comment

Looks good from me

Sign in to join this conversation.

No reviewers

modmuss50