Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Improve description of repositories blocks #81

Merged
YTG1234 merged 6 commits from patch-1 into master 2021-02-07 17:38:58 +00:00
Conversation 1 Commits 6 Files Changed 1 +16 -6
YTG1234 commented 2021-02-07 10:44:31 +00:00 (Migrated from github.com)
Copy Link

The repositories block inside the maven publish configuration does nothing but confuse new modders who want to use libraries.

If someone wants to publish their project to a maven repository, they probably know what they're doing and can figure out adding three lines of code.

This PR aims to fix that by adding another dependencies stub and improving the comments.

The `repositories` block inside the maven publish configuration does *nothing* but confuse new modders who want to use libraries. ~~If someone wants to publish their project to a maven repository, they probably know what they're doing and can figure out adding three lines of code.~~ This PR aims to fix that by adding another dependencies stub and improving the comments.
👍 4
Juuxel (Migrated from github.com) approved these changes 2021-02-07 10:46:06 +00:00
YanisBft (Migrated from github.com) approved these changes 2021-02-07 10:50:23 +00:00
ramidzkh (Migrated from github.com) approved these changes 2021-02-07 10:53:07 +00:00
liach commented 2021-02-07 13:26:30 +00:00 (Migrated from github.com)
Copy Link

I personally suggest adding a repositories stub above the dependencies block and describe what that repositories block does

I personally suggest adding a repositories stub above the dependencies block and describe what that repositories block does
liach (Migrated from github.com) approved these changes 2021-02-07 13:37:43 +00:00
Juuxel (Migrated from github.com) requested changes 2021-02-07 13:45:56 +00:00
build.gradle
Juuxel (Migrated from github.com) commented 2021-02-07 13:44:49 +00:00
Copy Link
    // Add repositories to retrieve artifacts from in here.
```suggestion // Add repositories to retrieve artifacts from in here. ```
Juuxel (Migrated from github.com) commented 2021-02-07 13:45:47 +00:00
Copy Link
    // Loom adds Maven Central and the Fabric maven automatically so you don't

(also technically the mojang maven but users don't have to care about that)

```suggestion // Loom adds Maven Central and the Fabric maven automatically so you don't ``` (also technically the mojang maven but users don't have to care about that)
build.gradle
Juuxel (Migrated from github.com) commented 2021-02-07 13:44:58 +00:00
Copy Link
        // retrieving dependencies.
```suggestion // retrieving dependencies. ```
YTG1234 (Migrated from github.com) reviewed 2021-02-07 13:50:10 +00:00
build.gradle
YTG1234 (Migrated from github.com) commented 2021-02-07 13:50:10 +00:00
Copy Link

Ah yes I can very much spell, thank you.

Ah yes I can very much spell, thank you.
liach (Migrated from github.com) reviewed 2021-02-07 13:50:46 +00:00
build.gradle
liach (Migrated from github.com) commented 2021-02-07 13:50:46 +00:00
Copy Link

if you really pick on that you should mention the Minecraft repo as well

if you really pick on that you should mention the Minecraft repo as well
YTG1234 (Migrated from github.com) reviewed 2021-02-07 13:50:58 +00:00
build.gradle
YTG1234 (Migrated from github.com) commented 2021-02-07 13:50:58 +00:00
Copy Link

How about "essential maven repositories" /s

How about "essential maven repositories" /s
YTG1234 (Migrated from github.com) reviewed 2021-02-07 13:53:31 +00:00
build.gradle
YTG1234 (Migrated from github.com) commented 2021-02-07 13:53:31 +00:00
Copy Link
    // Loom adds some essential maven repositories so you don't
```suggestion // Loom adds some essential maven repositories so you don't ```
liach (Migrated from github.com) reviewed 2021-02-07 13:57:24 +00:00
build.gradle
liach (Migrated from github.com) commented 2021-02-07 13:57:24 +00:00
Copy Link

I'd rather say you only use this when you need to depend on other mods

I'd rather say you only use this when you need to depend on other mods
YTG1234 (Migrated from github.com) reviewed 2021-02-07 14:02:31 +00:00
build.gradle
YTG1234 (Migrated from github.com) commented 2021-02-07 14:02:30 +00:00
Copy Link
    // Add repositories to retrieve artifacts from in here.
    // You should only use this when depending on other mods because
    // Loom adds the essential maven repositories to download Minecraft and libraries from automatically.
    // See https://docs.gradle.org/current/userguide/declaring_repositories.html
    // for more information about repositories.
```suggestion // Add repositories to retrieve artifacts from in here. // You should only use this when depending on other mods because // Loom adds the essential maven repositories to download Minecraft and libraries from automatically. // See https://docs.gradle.org/current/userguide/declaring_repositories.html // for more information about repositories. ```
Juuxel (Migrated from github.com) approved these changes 2021-02-07 15:40:00 +00:00
modmuss50 (Migrated from github.com) requested changes 2021-02-07 16:33:54 +00:00
build.gradle
modmuss50 (Migrated from github.com) commented 2021-02-07 16:33:51 +00:00
Copy Link

I wouldnt specifcy an exact line number as its going to move and this wont get updated.

I wouldnt specifcy an exact line number as its going to move and this wont get updated.
YTG1234 (Migrated from github.com) reviewed 2021-02-07 16:34:52 +00:00
build.gradle
YTG1234 (Migrated from github.com) commented 2021-02-07 16:34:52 +00:00
Copy Link
        // Notice: This block does NOT have the same function as the block in the top level.
```suggestion // Notice: This block does NOT have the same function as the block in the top level. ```
modmuss50 (Migrated from github.com) approved these changes 2021-02-07 17:38:50 +00:00
modmuss50 (Migrated from github.com) left a comment
Copy Link

Looks good now, many thanks.

Looks good now, many thanks.
Sign in to join this conversation.
Reviewers
No reviewers
YanisBft
ramidzkh
liach
Juuxel
modmuss50
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#81
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?