From a4260ec4fd3343b1c9d7775e531ab6bc19f26177 Mon Sep 17 00:00:00 2001 From: StoneLabs Date: Wed, 25 Aug 2021 17:17:32 +0200 Subject: [PATCH 1/4] Use Logger instead of println --- src/main/java/net/fabricmc/example/ExampleMod.java | 7 ++++++- src/main/java/net/fabricmc/example/mixin/ExampleMixin.java | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/fabricmc/example/ExampleMod.java b/src/main/java/net/fabricmc/example/ExampleMod.java index e5ed082..1f97d1f 100644 --- a/src/main/java/net/fabricmc/example/ExampleMod.java +++ b/src/main/java/net/fabricmc/example/ExampleMod.java @@ -1,14 +1,19 @@ package net.fabricmc.example; import net.fabricmc.api.ModInitializer; +import org.apache.logging.log4j.Level; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; public class ExampleMod implements ModInitializer { + public static final Logger LOGGER = LogManager.getLogger(); + @Override public void onInitialize() { // This code runs as soon as Minecraft is in a mod-load-ready state. // However, some things (like resources) may still be uninitialized. // Proceed with mild caution. - System.out.println("Hello Fabric world!"); + LOGGER.log(Level.INFO, "Hello Fabric world!"); } } diff --git a/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java b/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java index 83ee1a8..1aca2bb 100644 --- a/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java +++ b/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java @@ -1,6 +1,8 @@ package net.fabricmc.example.mixin; +import net.fabricmc.example.ExampleMod; import net.minecraft.client.gui.screen.TitleScreen; +import org.apache.logging.log4j.Level; import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.Inject; @@ -10,6 +12,6 @@ import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; public class ExampleMixin { @Inject(at = @At("HEAD"), method = "init()V") private void init(CallbackInfo info) { - System.out.println("This line is printed by an example mod mixin!"); + ExampleMod.LOGGER.log(Level.INFO, "This line is printed by an example mod mixin!"); } } -- 2.39.2 From cca1e7dab3f0b45c9f338ac369ebdfb2cdf9977e Mon Sep 17 00:00:00 2001 From: StoneLabs Date: Tue, 21 Sep 2021 14:03:49 +0200 Subject: [PATCH 2/4] Refactor Logger calls --- src/main/java/net/fabricmc/example/ExampleMod.java | 2 +- src/main/java/net/fabricmc/example/mixin/ExampleMixin.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/fabricmc/example/ExampleMod.java b/src/main/java/net/fabricmc/example/ExampleMod.java index 1f97d1f..3b59486 100644 --- a/src/main/java/net/fabricmc/example/ExampleMod.java +++ b/src/main/java/net/fabricmc/example/ExampleMod.java @@ -14,6 +14,6 @@ public class ExampleMod implements ModInitializer { // However, some things (like resources) may still be uninitialized. // Proceed with mild caution. - LOGGER.log(Level.INFO, "Hello Fabric world!"); + LOGGER.info("Hello Fabric world!"); } } diff --git a/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java b/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java index 1aca2bb..dc43814 100644 --- a/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java +++ b/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java @@ -12,6 +12,6 @@ import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; public class ExampleMixin { @Inject(at = @At("HEAD"), method = "init()V") private void init(CallbackInfo info) { - ExampleMod.LOGGER.log(Level.INFO, "This line is printed by an example mod mixin!"); + ExampleMod.LOGGER.info("This line is printed by an example mod mixin!"); } } -- 2.39.2 From b37ca0d707985cdf6a4170ffd8dc9db4ee8d96e3 Mon Sep 17 00:00:00 2001 From: StoneLabs Date: Tue, 21 Sep 2021 14:06:25 +0200 Subject: [PATCH 3/4] Remove old imports --- src/main/java/net/fabricmc/example/ExampleMod.java | 1 - src/main/java/net/fabricmc/example/mixin/ExampleMixin.java | 1 - 2 files changed, 2 deletions(-) diff --git a/src/main/java/net/fabricmc/example/ExampleMod.java b/src/main/java/net/fabricmc/example/ExampleMod.java index 3b59486..62ad392 100644 --- a/src/main/java/net/fabricmc/example/ExampleMod.java +++ b/src/main/java/net/fabricmc/example/ExampleMod.java @@ -1,7 +1,6 @@ package net.fabricmc.example; import net.fabricmc.api.ModInitializer; -import org.apache.logging.log4j.Level; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; diff --git a/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java b/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java index dc43814..356cb38 100644 --- a/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java +++ b/src/main/java/net/fabricmc/example/mixin/ExampleMixin.java @@ -2,7 +2,6 @@ package net.fabricmc.example.mixin; import net.fabricmc.example.ExampleMod; import net.minecraft.client.gui.screen.TitleScreen; -import org.apache.logging.log4j.Level; import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.Inject; -- 2.39.2 From 962b5dedbb37f15a10d5f34d579bd9ed0041de31 Mon Sep 17 00:00:00 2001 From: StoneLabs Date: Wed, 22 Sep 2021 00:10:01 +0200 Subject: [PATCH 4/4] Add name 'modid' to logger --- src/main/java/net/fabricmc/example/ExampleMod.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/net/fabricmc/example/ExampleMod.java b/src/main/java/net/fabricmc/example/ExampleMod.java index 62ad392..ad43b69 100644 --- a/src/main/java/net/fabricmc/example/ExampleMod.java +++ b/src/main/java/net/fabricmc/example/ExampleMod.java @@ -5,7 +5,10 @@ import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; public class ExampleMod implements ModInitializer { - public static final Logger LOGGER = LogManager.getLogger(); + // This logger is used to write text to the console and the log file. + // It is considered best practice to use your mod id as the logger's name. + // That way, it's clear which mod wrote info, warnings, and errors. + public static final Logger LOGGER = LogManager.getLogger("modid"); @Override public void onInitialize() { -- 2.39.2