Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Updated For Use With Loom 0.5-SNAPSHOT #67

Closed
alexis-evelyn wants to merge 2 commits from master into master
pull from: master
merge into: Steven:master
Conversation 6 Commits 2 Files Changed 4 +6 -2
4 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.gitignore vendored
View File

@@ -27,3 +27,6 @@ bin/
# fabric
run/
# OSX
.DS_Store

2
build.gradle
View File

@@ -1,5 +1,5 @@
plugins {
id 'fabric-loom' version '0.4-SNAPSHOT'
id 'fabric-loom' version '0.5-SNAPSHOT'
id 'maven-publish'
}

2
gradle.properties
View File

@@ -4,7 +4,7 @@ org.gradle.jvmargs=-Xmx1G
# Fabric Properties
# check these on https://fabricmc.net/use
minecraft_version=1.16.3
yarn_mappings=1.16.3+build.1
yarn_mappings=1.16.3+build.7
loader_version=0.9.3+build.207
# Mod Properties

1
settings.gradle
View File

@@ -6,5 +6,6 @@ pluginManagement {
url = 'https://maven.fabricmc.net/'
}
gradlePluginPortal()
mavenCentral()
modmuss50 commented 2020-09-18 07:57:03 +00:00 (Migrated from github.com)
Review
Copy Link

Is this needed?

Is this needed?
alexis-evelyn commented 2020-09-18 08:26:57 +00:00 (Migrated from github.com)
Review
Copy Link

It appears that it's not necessary. It was necessary 6 hours ago as Gradle kept complaining it could not find the 3.9.0 version of this artifact. My guess is, Loom is using the maven central versions of the packages while the Gradle settings from the example mod are using JCenter to find these packages.

I would say that it's not strictly necessary except when Loom starts to use a new version of a dependency that hasn't been synced to JCenter yet. In my opinion, this would cut down on issues that relate to not finding an artifact that just hasn't synced yet (as I wasn't the only one on FabricMC's Discord today asking about it). After the artifact syncs, the link to Maven Central is no longer needed.

I'd say it's up to you whether or not I should remove the Maven Central link. Maybe we can just leave it commented out if you want.

Edit: I should mention, I noticed this issue as it caused my automated build script to fail. My build script is setup with an existing mod I've been working on for months, so I was surprised to find it all of a suddenly failing to compile (and the error message suggesting Loom out of all things). My strongest point to argue we should have Maven Central in the settings file is to help prevent dependency breakage from occurring to people who won't be able to discern the fix as easily. This will also help a lot with automated build scripts as the script failed without any dependency changes and certainly caught me by surprise. While I now personally keep Maven Central in my settings file, but this will be able to help other people who would not think about doing this. I didn't even think about it until I needed to today.

It appears that it's not necessary. It was necessary 6 hours ago as Gradle kept complaining it could not find the 3.9.0 version of [this artifact](https://bintray.com/bintray/jcenter/org.eclipse.platform%3Aorg.eclipse.equinox.registry/3.9.0). My guess is, Loom is using the [maven central versions](https://mvnrepository.com/artifact/org.eclipse.platform/org.eclipse.equinox.registry/3.9.0) of the packages while the Gradle settings from the example mod are using JCenter to find these packages. I would say that it's not strictly necessary except when Loom starts to use a new version of a dependency that hasn't been synced to JCenter yet. In my opinion, this would cut down on issues that relate to not finding an artifact that just hasn't synced yet (as I wasn't the only one on FabricMC's Discord today asking about it). After the artifact syncs, the link to Maven Central is no longer needed. I'd say it's up to you whether or not I should remove the Maven Central link. Maybe we can just leave it commented out if you want. Edit: I should mention, I noticed this issue as it caused my automated build script to fail. My build script is setup with an existing mod I've been working on for months, so I was surprised to find it all of a suddenly failing to compile (and the error message suggesting Loom out of all things). My strongest point to argue we should have Maven Central in the settings file is to help prevent dependency breakage from occurring to people who won't be able to discern the fix as easily. This will also help a lot with automated build scripts as the script failed without any dependency changes and certainly caught me by surprise. While I now personally keep Maven Central in my settings file, but this will be able to help other people who would not think about doing this. I didn't even think about it until I needed to today.
}
}