gradle configuration update #7

Merged
UpcraftLP merged 9 commits from gradle-update into master 2019-02-16 00:17:56 +00:00
2 changed files with 21 additions and 3 deletions
Showing only changes of commit 8243775b5c - Show all commits

View File

@ -23,6 +23,24 @@ dependencies {
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modCompile "net.fabricmc:fabric:${project.fabric_version}"
}
processResources {
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
// this will ensure that this task is re-run when there's a change
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
inputs.property "version", project.version
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
// replace stuff in fabric.mod.json, nothing else
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
from(sourceSets.main.resources.srcDirs) {
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
include "fabric.mod.json"
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
// add mod metadata
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
expand "version": project.version
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:55 +00:00 (Migrated from github.com)
Review

Do we really need a javadoc?

Do we really need a javadoc?
UpcraftLP commented 2019-02-15 21:04:43 +00:00 (Migrated from github.com)
Review

well I thought it'd be a nice-to-have, mainly for including it in the maven publication

well I thought it'd be a nice-to-have, mainly for including it in the maven publication
modmuss50 commented 2019-02-15 21:31:44 +00:00 (Migrated from github.com)
Review

It adds quite a bit more to the build.gradle (due to the fix bellow). And there are source jars anyway so when you depend on a mod it should give you sources.

It adds quite a bit more to the build.gradle (due to the fix bellow). And there are source jars anyway so when you depend on a mod it should give you sources.
}
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
// copy everything else, thats not the mcmod.info
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
from(sourceSets.main.resources.srcDirs) {
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
exclude "fabric.mod.json"
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
}
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
}
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
// ensure that the encoding is set to UTF-8, no matter what the system default is
// this fixes some edge cases with special characters not displaying correctly
// see http://yodaconditions.net/blog/fix-for-java-file-encoding-problems-with-gradle.html
@ -34,7 +52,7 @@ tasks.withType(JavaCompile) {
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
// if it is present.
// If you remove this task, sources will not be generated.
task sourcesJar(type: Jar, dependsOn: classes) {
classifier = 'sources'
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
classifier = "sources"
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
from sourceSets.main.allSource
}
@ -51,7 +69,7 @@ task javadocJar(type: Jar, dependsOn: javadoc) {
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
if (JavaVersion.current().isJava8Compatible()) {
allprojects {
tasks.withType(Javadoc) {
options.addStringOption('Xdoclint:none', '-quiet')
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
options.addStringOption("Xdoclint:none", "-quiet")
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
}
}
}

modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation
modmuss50 commented 2019-02-15 21:03:34 +00:00 (Migrated from github.com)
Review

Bad indentation

Bad indentation

View File

@ -2,7 +2,7 @@
"id": "modid",
"name": "Example Mod",
"description": "This is an example description! Tell everyone what your mod is about!",
"version": "1.0.0",
"version": "${version}",
"side": "universal",
"initializers": [
"net.fabricmc.example.ExampleMod"