Add tons of Typescript strictness

src/main.ts

@@ -1,19 +1,23 @@
 import * as fs from 'fs'
+import {Octokit} from '@octokit/core'
+import {Endpoints} from '@octokit/types'
 import * as core from '@actions/core'
 import * as github from '@actions/github'
 import * as path from 'path'
+import * as glob from 'glob'
 
-const glob = require('glob')
+type RepoAssetsResp = Endpoints['GET /repos/:owner/:repo/releases/:release_id/assets']['response']
+type ReleaseByTagResp = Endpoints['GET /repos/:owner/:repo/releases/tags/:tag']['response']
+type CreateReleaseResp = Endpoints['POST /repos/:owner/:repo/releases']['response']
 
 async function get_release_by_tag(
   tag: string,
-  octokit: any,
-  context: any
-): Promise<any> {
+  octokit: Octokit
+): Promise<ReleaseByTagResp | CreateReleaseResp> {
   try {
     core.debug(`Getting release by tag ${tag}.`)
     return await octokit.repos.getReleaseByTag({
-      ...context.repo,
+      ...github.context.repo,
       tag: tag
     })
   } catch (error) {
@@ -23,7 +27,7 @@ async function get_release_by_tag(
         `Release for tag ${tag} doesn't exist yet so we'll create it now.`
       )
       return await octokit.repos.createRelease({
-        ...context.repo,
+        ...github.context.repo,
         tag_name: tag
       })
     } else {
@@ -33,14 +37,13 @@ async function get_release_by_tag(
 }
 
 async function upload_to_release(
-  release: any,
+  release: ReleaseByTagResp | CreateReleaseResp,
   file: string,
   asset_name: string,
   tag: string,
   overwrite: string,
-  octokit: any,
-  context: any
-) {
+  octokit: Octokit
+): Promise<void> {
   const stat = fs.statSync(file)
   if (!stat.isFile()) {
     core.debug(`Skipping ${file}, since its not a file`)
@@ -50,18 +53,18 @@ async function upload_to_release(
   const file_bytes = fs.readFileSync(file)
 
   // Check for duplicates.
-  const assets = await octokit.repos.listAssetsForRelease({
-    ...context.repo,
+  const assets: RepoAssetsResp = await octokit.repos.listAssetsForRelease({
+    ...github.context.repo,
     release_id: release.data.id
   })
-  const duplicate_asset = assets.data.find((a: any) => a.name === asset_name)
+  const duplicate_asset = assets.data.find(a => a.name === asset_name)
   if (duplicate_asset !== undefined) {
     if (overwrite === 'true') {
       core.debug(
         `An asset called ${asset_name} already exists in release ${tag} so we'll overwrite it.`
       )
       await octokit.repos.deleteReleaseAsset({
-        ...context.repo,
+        ...github.context.repo,
         asset_id: duplicate_asset.id
       })
     } else {
@@ -86,7 +89,7 @@ async function upload_to_release(
   })
 }
 
-async function run() {
+async function run(): Promise<void> {
   try {
     const token = core.getInput('repo_token', {required: true})
     const file = core.getInput('file', {required: true})
@@ -94,14 +97,13 @@ async function run() {
     const tag = core.getInput('tag', {required: true}).replace('refs/tags/', '')
     const overwrite = core.getInput('overwrite')
 
-    const octokit = github.getOctokit(token)
-    const context = github.context
-    const release = await get_release_by_tag(tag, octokit, context)
+    const octokit: Octokit = github.getOctokit(token)
+    const release = await get_release_by_tag(tag, octokit)
 
     if (file_glob === 'true') {
       const files = glob.sync(file)
       if (files.length > 0) {
-        for (let file of files) {
+        for (const file of files) {
           const asset_name = path.basename(file)
           await upload_to_release(
             release,
@@ -109,8 +111,7 @@ async function run() {
             asset_name,
             tag,
             overwrite,
-            octokit,
-            context
+            octokit
           )
         }
       } else {
@@ -126,8 +127,7 @@ async function run() {
         asset_name,
         tag,
         overwrite,
-        octokit,
-        context
+        octokit
       )
     }
   } catch (error) {