2.5.0

Add retry to upload release (UPDATED VERSION)

.eslintignore

@@ -0,0 +1,3 @@
+dist/
+lib/
+node_modules/

.eslintrc.json

@@ -0,0 +1,54 @@
+{
+    "plugins": ["jest", "@typescript-eslint", "github"],
+    "extends": ["plugin:github/typescript"],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": 9,
+        "sourceType": "module",
+        "project": "./tsconfig.json"
+    },
+    "rules": {
+        "eslint-comments/no-use": "off",
+        "import/no-namespace": "off",
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": "error",
+        "@typescript-eslint/explicit-member-accessibility": ["error", {
+            "accessibility": "no-public"
+        }],
+        "@typescript-eslint/no-require-imports": "error",
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/await-thenable": "error",
+        "@typescript-eslint/explicit-function-return-type": ["error", {
+            "allowExpressions": true
+        }],
+        "@typescript-eslint/func-call-spacing": ["error", "never"],
+        "@typescript-eslint/no-array-constructor": "error",
+        "@typescript-eslint/no-empty-interface": "error",
+        "@typescript-eslint/no-extraneous-class": "error",
+        "@typescript-eslint/no-for-in-array": "error",
+        "@typescript-eslint/no-inferrable-types": "error",
+        "@typescript-eslint/no-misused-new": "error",
+        "@typescript-eslint/no-namespace": "error",
+        "@typescript-eslint/no-non-null-assertion": "warn",
+        "@typescript-eslint/no-unnecessary-qualifier": "error",
+        "@typescript-eslint/no-unnecessary-type-assertion": "error",
+        "@typescript-eslint/no-useless-constructor": "error",
+        "@typescript-eslint/no-var-requires": "error",
+        "@typescript-eslint/prefer-for-of": "warn",
+        "@typescript-eslint/prefer-function-type": "warn",
+        "@typescript-eslint/prefer-includes": "error",
+        "@typescript-eslint/prefer-string-starts-ends-with": "error",
+        "@typescript-eslint/promise-function-async": "error",
+        "@typescript-eslint/require-array-sort-compare": "error",
+        "@typescript-eslint/restrict-plus-operands": "error",
+        "semi": "off",
+        "@typescript-eslint/semi": ["error", "never"],
+        "@typescript-eslint/type-annotation-spacing": "error",
+        "@typescript-eslint/unbound-method": "error"
+    },
+    "env": {
+        "node": true,
+        "es6": true,
+        "jest/globals": true
+    }
+}

.github/FUNDING.yml

@@ -0,0 +1 @@
+github: svenstaro

.github/workflows/checkin.yml

@@ -1,25 +0,0 @@
-name: "PR Checks"
-on: [pull_request, push]
-
-jobs:
-  check_pr:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v1
-
-    - name: "npm ci"
-      run: npm ci
-
-    - name: "npm run build"
-      run: npm run build
-
-    - name: "npm run test"
-      run: npm run test
-
-    - name: "check for uncommitted changes"
-      # Ensure no changes, but ignore node_modules dir since dev/fresh ci deps installed.
-      run: |
-        git diff --exit-code --stat -- . ':!node_modules' \
-        || (echo "##[error] found changed files after build. please 'npm run build && npm run format'" \
-                 "and check in all changes" \
-            && exit 1)

.github/workflows/ci.yml

@@ -0,0 +1,71 @@
+name: "CI"
+on: [pull_request, push]
+
+jobs:
+  build: # make sure build/ci work properly
+    name: CI on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    steps:
+    - uses: actions/checkout@v3
+    - run: |
+        npm install
+        npm run all
+
+  test: # make sure the action works on a clean machine without building
+    name: E2E test
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    steps:
+    - uses: actions/checkout@v3
+    - name: Make test pre-release
+      uses: ./
+      with:
+        repo_token: ${{ secrets.GITHUB_TOKEN }}
+        file: README.md
+        asset_name: TEST.md
+        tag: ci-test-${{ matrix.os }}-${{ github.run_id }}
+        overwrite: true
+        prerelease: true
+        body: "rofl lol test%0Aianal %25 fubar"
+    - name: Check that the uploaded asset is readable
+      uses: actions/github-script@v2
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        script: |
+          const fs = require('fs')
+          const child_process = require('child_process');
+          const assert = require('assert').strict;
+
+          const expected = fs.readFileSync("README.md")
+          const release = await github.repos.getReleaseByTag({
+            ...context.repo,
+            tag: "ci-test-${{ matrix.os }}-${{ github.run_id }}",
+          })
+          assert.deepStrictEqual(release.data.prerelease, true)
+          assert.deepStrictEqual(release.data.body, "rofl lol test\nianal % fubar")
+          assert.deepStrictEqual(release.data.assets[0].name, "TEST.md")
+          const actual = child_process.execSync(`curl -Ls ${release.data.assets[0].browser_download_url}`)
+          assert.deepStrictEqual(expected, actual)
+    - name: Clean up
+      if: ${{ always() }}
+      uses: actions/github-script@v2
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        script: |
+          const release = await github.repos.getReleaseByTag({
+            ...context.repo,
+            tag: "ci-test-${{ matrix.os }}-${{ github.run_id }}",
+          })
+          await github.repos.deleteRelease({
+            ...context.repo,
+            release_id: release.data.id,
+          })
+          await github.git.deleteRef({
+            ...context.repo,
+            ref: "tags/ci-test-${{ matrix.os }}-${{ github.run_id }}",
+          })

.github/workflows/versioning.yml

@@ -0,0 +1,15 @@
+name: Keep the versions up-to-date
+
+on:
+  release:
+    types: [published, edited]
+
+jobs:
+  actions-tagger:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: Actions-R-Us/actions-tagger@latest
+        env:
+          GITHUB_TOKEN: "${{secrets.GITHUB_TOKEN}}"
+        with:
+          publish_latest_tag: true

.gitignore

@@ -1,3 +1,4 @@
-node_modules/
+node_modules
-__tests__/runner/*
 run.sh
+__tests__/runner/*
+lib/**/*

.prettierignore

@@ -0,0 +1,3 @@
+dist/
+lib/
+node_modules/

.prettierrc.json

@@ -0,0 +1,11 @@
+{
+    "printWidth": 80,
+    "tabWidth": 2,
+    "useTabs": false,
+    "semi": false,
+    "singleQuote": true,
+    "trailingComma": "none",
+    "bracketSpacing": false,
+    "arrowParens": "avoid",
+    "parser": "typescript"
+}

CHANGELOG.md

@@ -0,0 +1,34 @@
+# Changelog
+
+## [2.5.0] - 2023-02-21
+- Add retry to upload release [#96](https://github.com/svenstaro/upload-release-action/pull/96) (thanks @sonphantrung)
+
+## [2.4.1] - 2023-02-01
+- Modernize octokit usage
+
+## [2.4.0] - 2023-01-09
+- Update to node 16
+- Bump most dependencies
+
+## [2.3.0] - 2022-06-05
+- Now defaults `repo_token` to `${{ github.token }}` and `tag` to `${{ github.ref }}` [#69](https://github.com/svenstaro/upload-release-action/pull/69) (thanks @leighmcculloch)
+
+## [2.2.1] - 2020-12-16
+- Added support for the GitHub pagination API for repositories with many releases [#36](https://github.com/svenstaro/upload-release-action/pull/36) (thanks @djpohly)
+
+## [2.2.0] - 2020-10-07
+- Add support for ceating a new release in a foreign repository [#25](https://github.com/svenstaro/upload-release-action/pull/25) (thanks @kittaakos)
+- Upgrade all deps
+
+## [2.1.1] - 2020-09-25
+- Fix `release_name` option [#27](https://github.com/svenstaro/upload-release-action/pull/27) (thanks @kittaakos)
+
+## [2.1.0] - 2020-08-10
+- Strip refs/heads/ from the input tag [#23](https://github.com/svenstaro/upload-release-action/pull/23) (thanks @OmarEmaraDev)
+
+## [2.0.0] - 2020-07-03
+- Add `prerelease` input parameter. Setting this marks the created release as a pre-release.
+- Add `release_name` input parameter. Setting this explicitly sets the title of the release.
+- Add `body` input parameter. Setting this sets the text content of the created release.
+- Add `browser_download_url` output variable. This contains the publicly accessible download URL of the uploaded artifact.
+- Allow for leaving `asset_name` unset. This will cause the asset to use the filename.

README.md

@@ -1,17 +1,30 @@
-# Upload files to a GitHub release
+# Upload files to a GitHub release [![GitHub Actions Workflow](https://github.com/svenstaro/upload-release-action/actions/workflows/ci.yml/badge.svg)](https://github.com/svenstaro/upload-release-action/actions)
 
 This action allows you to select which files to upload to the just-tagged release.
 It runs on all operating systems types offered by GitHub.
 
-## Input variables:
+## Input variables
 
 You must provide:
 
-- `repo_token`: Usually you'll want to set this to `${{ secrets.GITHUB_TOKEN }}`
 - `file`: A local file to be uploaded as the asset.
-- `asset_name`: The name the file gets as an asset on a release.
+
-- `tag`: The tag to uploaded into. If you want the current event's tag, use `${{ github.event.ref }}`
+Optional Arguments
-- `overwrite`: If an asset with name already exists, overwrite it.
+
+- `repo_token`: Defaults to `github.token`.
+- `tag`: The tag to upload into. If you want the current event's tag or branch name, use `${{ github.ref }}` (the `refs/tags/` and `refs/heads/` prefixes will be automatically stripped). Defaults to `github.ref`.
+- `asset_name`: The name the file gets as an asset on a release. Use `$tag` to include the tag name. When not provided it will default to the filename.
+                This is not used if `file_glob` is set to `true`.
+- `file_glob`: If set to true, the file argument can be a glob pattern (`asset_name` is ignored in this case) (Default: `false`)
+- `overwrite`: If an asset with the same name already exists, overwrite it (Default: `false`).
+- `prerelease`: Mark the release as a pre-release (Default: `false`).
+- `release_name`: Explicitly set a release name. (Defaults: implicitly same as `tag` via GitHub API).
+- `body`: Content of the release text (Default: `""`).
+- `repo_name`: Specify the name of the GitHub repository in which the GitHub release will be created, edited, and deleted. If the repository is other than the current, it is required to create a personal access token with `repo`, `user`, `admin:repo_hook` scopes to the foreign repository and add it as a secret. (Default: current repository).
+
+## Output variables
+
+- `browser_download_url`: The publicly available URL of the asset.
 
 ## Usage
 
@@ -24,8 +37,9 @@ Simple example:
 name: Publish
 
 on:
-  create:
+  push:
     tags:
+      - '*'
 
 jobs:
   build:
@@ -33,20 +47,18 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: hecrj/setup-rust-action@v1-release
+    - uses: actions/checkout@v3
-      with:
-        rust-version: stable
-    - uses: actions/checkout@v1
     - name: Build
       run: cargo build --release
     - name: Upload binaries to release
-      uses: svenstaro/upload-release-action@v1-release
+      uses: svenstaro/upload-release-action@v2
       with:
         repo_token: ${{ secrets.GITHUB_TOKEN }}
         file: target/release/mything
         asset_name: mything
-        tag: {{ github.event.ref }}
+        tag: ${{ github.ref }}
         overwrite: true
+        body: "This is my release text"
 ```
 
 Complex example with more operating systems:
@@ -55,11 +67,12 @@ Complex example with more operating systems:
 name: Publish
 
 on:
-  create:
+  push:
     tags:
+      - '*'
 
 jobs:
-  build:
+  publish:
     name: Publish for ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
@@ -76,16 +89,132 @@ jobs:
             asset_name: mything-macos-amd64
 
     steps:
-    - uses: hecrj/setup-rust-action@v1-release
+    - uses: actions/checkout@v3
-      with:
-        rust-version: stable
-    - uses: actions/checkout@v1
     - name: Build
-      run: cargo build --release
+      run: cargo build --release --locked
     - name: Upload binaries to release
-      uses: svenstaro/upload-release-action@v1-release
+      uses: svenstaro/upload-release-action@v2
       with:
         repo_token: ${{ secrets.GITHUB_TOKEN }}
         file: target/release/${{ matrix.artifact_name }}
         asset_name: ${{ matrix.asset_name }}
+        tag: ${{ github.ref }}
 ```
+
+Example with `file_glob`:
+
+```yaml
+name: Publish
+on:
+  push:
+    tags:
+      - '*'
+
+jobs:
+  build:
+    name: Publish binaries
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Build
+      run: cargo build --release
+    - name: Upload binaries to release
+      uses: svenstaro/upload-release-action@v2
+      with:
+        repo_token: ${{ secrets.GITHUB_TOKEN }}
+        file: target/release/my*
+        tag: ${{ github.ref }}
+        overwrite: true
+        file_glob: true
+```
+
+Example for creating a release in a foreign repository using `repo_name`:
+
+```yaml
+name: Publish
+
+on:
+  push:
+    tags:
+      - '*'
+
+jobs:
+  build:
+    name: Publish binaries
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Build
+      run: cargo build --release
+    - name: Upload binaries to release
+      uses: svenstaro/upload-release-action@v2
+      with:
+        repo_name: owner/repository-name
+        # A personal access token for the GitHub repository in which the release will be created and edited.
+        # It is recommended to create the access token with the following scopes: `repo, user, admin:repo_hook`.
+        repo_token: ${{ secrets.YOUR_PERSONAL_ACCESS_TOKEN }}
+        file: target/release/mything
+        asset_name: mything
+        tag: ${{ github.ref }}
+        overwrite: true
+        body: "This is my release text"
+```
+
+**Example for feeding a file from repo to the `body` tag:**
+
+This example covers following points:
+* Reading a file present on the repo. For example, `release.md` which is placed in root directory of the repo.
+* Modify & push the `release.md` file before triggering this action (create tag for this example) to dynamically change the body of the release.
+
+```yaml
+name: Publish
+
+on:
+  push:
+    tags:
+      - '*'
+
+jobs:
+
+  build:
+    name: Publish binaries
+    runs-on: ubuntu-latest
+         
+    steps:
+      - uses: actions/checkout@v3
+
+      # This step reads a file from repo and use it for body of the release
+      # This works on any self-hosted runner OS
+      - name: Read release.md and use it as a body of new release
+        id: read_release
+        shell: bash
+        run: |
+          r=$(cat path/to/release.md)                       # <--- Read release.md (Provide correct path as per your repo)
+          r="${r//'%'/'%25'}"                               # Multiline escape sequences for %
+          r="${r//$'\n'/'%0A'}"                             # Multiline escape sequences for '\n'
+          r="${r//$'\r'/'%0D'}"                             # Multiline escape sequences for '\r'
+          echo "RELEASE_BODY=$r" >> $GITHUB_OUTPUT          # <--- Set environment variable
+
+      - name: Upload Binaries to Release
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          tag: ${{ github.ref }}
+          body: |
+            ${{ steps.read_release.outputs.RELEASE_BODY }}  # <--- Use environment variables that was created earlier
+
+```
+
+
+## Releasing
+
+To release this Action:
+
+- Bump version in `package.json`
+- Create `CHANGELOG.md` entry
+- `npm run all`
+- `git commit -am <version>`
+- `git tag -sm <version> <version>`
+- `git push --follow-tags`
+- Go to https://github.com/svenstaro/upload-release-action/releases and publish the new version

__tests__/main.test.ts

@@ -1,6 +1,25 @@
-import * as main from '../src/main';
+import * as github from '@actions/github'
+import * as main from '../src/main'
 
 // Frankly, tests would be entirely useless unless we can mock GitHub somehow.
 describe('Upload Release Action', () => {
-  it('', async () => {});
+  let spyGetOctokit: jest.SpyInstance<any>
-});
+  let mockOctokit: any
+
+  beforeEach(() => {
+    mockOctokit = {
+      repos: {
+        createRelease: jest.fn(async () => ({
+          data: {
+            id: 'lalala',
+            upload_url: 'oaoa'
+          }
+        }))
+      }
+    }
+    // spyGetOctokit = jest.spyOn(github, "getOctokit").mockImplementation(() => mockOctokit
+    // jest.spyOn(github, "context", "get").mockImplementation(() => "testtest");
+  })
+
+  it('pls write actual test', async () => {})
+})

action.yml

@@ -6,19 +6,33 @@ branding:
   color: orange
 inputs:
   repo_token:
-    description: 'GitHub token'
+    description: 'GitHub token.'
     required: true
+    default: ${{ github.token }}
   file:
-    description: 'Local file to upload'
+    description: 'Local file to upload.'
-    required: true
-  asset_name:
-    description: 'Name of the asset'
     required: true
   tag:
-    description: 'Tag to use as a release'
+    description: 'Tag to use as a release.'
     required: true
+    default: ${{ github.ref }}
+  asset_name:
+    description: 'Name of the asset. When not provided will use the file name. Unused if file_glob is set to "true".'
   overwrite:
-    description: 'Overwrite the release in case it already exists'
+    description: 'Overwrite the release in case it already exists.'
+  file_glob:
+    description: 'If true the file can be a glob pattern, asset_name is ignored if this is true.'
+  prerelease:
+    description: 'Mark the release as a pre-release. Defaults to "false".'
+  release_name:
+    description: 'Explicitly set a release name. Defaults to empty which will cause the release to take the tag as name on GitHub.'
+  body:
+    description: 'Content of the release text. Empty by default.'
+  repo_name:
+    description: 'Specify the name of the GitHub repository in which the GitHub release will be created, edited, and deleted. If the repository is other than the current, it is required to create a personal access token with `repo`, `user`, `admin:repo_hook` scopes to the foreign repository and add it as a secret. Defaults to the current repository'
+outputs:
+  browser_download_url:
+    description: 'The publicly available URL of the asset.'
 runs:
-  using: 'node12'
+  using: 'node16'
-  main: 'lib/main.js'
+  main: 'dist/index.js'

docs/contributors.md

@@ -1,22 +0,0 @@
-# Contributors
-
-### Checkin
-
-- Do checkin source (src)
-- Do checkin build output (lib)
-- Do checkin runtime node_modules
-- Do not checkin devDependency node_modules (husky can help see below)
-
-### devDependencies
-
-In order to handle correctly checking in node_modules without devDependencies, we run [Husky](https://github.com/typicode/husky) before each commit.
-This step ensures that formatting and checkin rules are followed and that devDependencies are excluded. To make sure Husky runs correctly, please use the following workflow:
-
-```
-npm install                                 # installs all devDependencies including Husky
-git add abc.ext                             # Add the files you've changed. This should include files in src, lib, and node_modules (see above)
-git commit -m "Informative commit message"  # Commit. This will run Husky
-```
-
-During the commit step, Husky will take care of formatting all files with [Prettier](https://github.com/prettier/prettier) as well as pruning out devDependencies using `npm prune --production`.
-It will also make sure these changes are appropriately included in your commit (no further work is needed)

lib/main.js

@@ -1,92 +0,0 @@
-"use strict";
-var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
-    return new (P || (P = Promise))(function (resolve, reject) {
-        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
-        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
-        function step(result) { result.done ? resolve(result.value) : new P(function (resolve) { resolve(result.value); }).then(fulfilled, rejected); }
-        step((generator = generator.apply(thisArg, _arguments || [])).next());
-    });
-};
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (Object.hasOwnProperty.call(mod, k)) result[k] = mod[k];
-    result["default"] = mod;
-    return result;
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-const fs = __importStar(require("fs"));
-const core = __importStar(require("@actions/core"));
-const github = __importStar(require("@actions/github"));
-function get_release_by_tag(tag, octokit, context) {
-    return __awaiter(this, void 0, void 0, function* () {
-        try {
-            core.debug(`Getting release by tag ${tag}.`);
-            return yield octokit.repos.getReleaseByTag(Object.assign({}, context.repo, { tag: tag }));
-        }
-        catch (error) {
-            // If this returns 404, we need to create the release first.
-            if (error.status === 404) {
-                core.debug(`Release for tag ${tag} doesn't exist yet so we'll create it now.`);
-                return yield octokit.repos.createRelease(Object.assign({}, context.repo, { tag_name: tag }));
-            }
-            else {
-                throw error;
-            }
-        }
-    });
-}
-function upload_to_release(release, file, asset_name, tag, overwrite, octokit, context) {
-    return __awaiter(this, void 0, void 0, function* () {
-        const file_size = fs.statSync(file).size;
-        const file_bytes = fs.readFileSync(file);
-        // Check for duplicates.
-        const assets = yield octokit.repos.listAssetsForRelease(Object.assign({}, context.repo, { release_id: release.data.id }));
-        const duplicate_asset = assets.data.find(a => a.name === asset_name);
-        if (duplicate_asset !== undefined) {
-            if (overwrite === "true") {
-                core.debug(`An asset called ${asset_name} already exists in release ${tag} so we'll overwrite it.`);
-                yield octokit.repos.deleteReleaseAsset(Object.assign({}, context.repo, { asset_id: duplicate_asset.id }));
-            }
-            else {
-                core.setFailed(`An asset called ${asset_name} already exists.`);
-                return;
-            }
-        }
-        else {
-            core.debug(`No pre-existing asset called ${asset_name} found in release ${tag}. All good.`);
-        }
-        core.debug(`Uploading ${file} to ${asset_name} in release ${tag}.`);
-        yield octokit.repos.uploadReleaseAsset({
-            url: release.data.upload_url,
-            name: asset_name,
-            file: file_bytes,
-            headers: {
-                "content-type": "binary/octet-stream",
-                "content-length": file_size
-            },
-        });
-    });
-}
-function run() {
-    return __awaiter(this, void 0, void 0, function* () {
-        try {
-            const token = core.getInput('repo_token', { required: true });
-            const file = core.getInput('file', { required: true });
-            const asset_name = core.getInput('asset_name', { required: true });
-            const tag = core.getInput('tag', { required: true });
-            const overwrite = core.getInput('overwrite');
-            if (!fs.existsSync(file)) {
-                core.setFailed(`File ${file} wasn't found.`);
-            }
-            const octokit = new github.GitHub(token);
-            const context = github.context;
-            const release = yield get_release_by_tag(tag, octokit, context);
-            yield upload_to_release(release, file, asset_name, tag, overwrite, octokit, context);
-        }
-        catch (error) {
-            core.setFailed(error.message);
-        }
-    });
-}
-run();

package.json

@@ -1,12 +1,17 @@
 {
   "name": "upload-release-action",
-  "version": "1.0.0",
+  "version": "2.5.0",
   "private": true,
   "description": "Upload files to a GitHub release",
   "main": "lib/main.js",
   "scripts": {
     "build": "tsc",
-    "test": "jest"
+    "format": "prettier --write **/*.ts",
+    "format-check": "prettier --check **/*.ts",
+    "lint": "eslint src/**/*.ts",
+    "pack": "ncc build",
+    "test": "jest",
+    "all": "npm run build && npm run format && npm run lint && npm run pack && npm test"
   },
   "repository": {
     "type": "git",
@@ -22,15 +27,25 @@
   "author": "Sven-Hendrik Haase",
   "license": "MIT",
   "dependencies": {
-    "@actions/core": "^1.0.0",
+    "@actions/core": "^1.10.0",
-    "@actions/github": "^1.0.0"
+    "@actions/github": "^5",
+    "@lifeomic/attempt": "^3.0.3",
+    "glob": "^7"
   },
   "devDependencies": {
-    "@types/jest": "^24.0.13",
+    "@types/glob": "^7",
-    "@types/node": "^12.0.4",
+    "@types/jest": "^29",
-    "jest": "^24.8.0",
+    "@types/node": "^16",
-    "jest-circus": "^24.7.1",
+    "@typescript-eslint/parser": "^5",
-    "ts-jest": "^24.0.2",
+    "@vercel/ncc": "^0.36.0",
-    "typescript": "^3.5.1"
+    "eslint": "^8",
+    "eslint-plugin-github": "^4.6",
+    "eslint-plugin-jest": "^27",
+    "jest": "^29",
+    "jest-circus": "^29",
+    "js-yaml": "^4",
+    "prettier": "^2.8",
+    "ts-jest": "^29",
+    "typescript": "^4"
   }
 }

src/main.ts

@@ -1,85 +1,206 @@
-import * as fs from 'fs';
+import * as fs from 'fs'
-import * as core from '@actions/core';
+import {Octokit} from '@octokit/core'
-import * as github from '@actions/github';
+import {Endpoints} from '@octokit/types'
+import * as core from '@actions/core'
+import * as github from '@actions/github'
+import * as path from 'path'
+import * as glob from 'glob'
+import {retry} from '@lifeomic/attempt'
 
-async function get_release_by_tag(tag: string, octokit: any, context: any): Promise<any> {
+const releaseByTag = 'GET /repos/{owner}/{repo}/releases/tags/{tag}' as const
-    try {
+const createRelease = 'POST /repos/{owner}/{repo}/releases' as const
-        core.debug(`Getting release by tag ${tag}.`);
+const repoAssets =
-        return await octokit.repos.getReleaseByTag({
+  'GET /repos/{owner}/{repo}/releases/{release_id}/assets' as const
-            ...context.repo,
+const uploadAssets =
-            tag: tag,
+  'POST {origin}/repos/{owner}/{repo}/releases/{release_id}/assets{?name,label}' as const
-        });
+const deleteAssets =
-    } catch (error) {
+  'DELETE /repos/{owner}/{repo}/releases/assets/{asset_id}' as const
-        // If this returns 404, we need to create the release first.
+
-        if (error.status === 404) {
+type ReleaseByTagResp = Endpoints[typeof releaseByTag]['response']
-            core.debug(`Release for tag ${tag} doesn't exist yet so we'll create it now.`)
+type CreateReleaseResp = Endpoints[typeof createRelease]['response']
-            return await octokit.repos.createRelease({
+type RepoAssetsResp = Endpoints[typeof repoAssets]['response']['data']
-                ...context.repo,
+type UploadAssetResp = Endpoints[typeof uploadAssets]['response']
-                tag_name: tag,
+
-            })
+async function get_release_by_tag(
-        } else {
+  tag: string,
-            throw error;
+  prerelease: boolean,
-        }
+  release_name: string,
+  body: string,
+  octokit: Octokit
+): Promise<ReleaseByTagResp | CreateReleaseResp> {
+  try {
+    core.debug(`Getting release by tag ${tag}.`)
+    return await octokit.request(releaseByTag, {
+      ...repo(),
+      tag: tag
+    })
+  } catch (error: any) {
+    // If this returns 404, we need to create the release first.
+    if (error.status === 404) {
+      core.debug(
+        `Release for tag ${tag} doesn't exist yet so we'll create it now.`
+      )
+      return await octokit.request(createRelease, {
+        ...repo(),
+        tag_name: tag,
+        prerelease: prerelease,
+        name: release_name,
+        body: body
+      })
+    } else {
+      throw error
     }
+  }
 }
 
-async function upload_to_release(release: any, file: string, asset_name: string, tag: string, overwrite: string, octokit: any, context: any) {
+async function upload_to_release(
-    const file_size = fs.statSync(file).size;
+  release: ReleaseByTagResp | CreateReleaseResp,
-    const file_bytes = fs.readFileSync(file);
+  file: string,
+  asset_name: string,
+  tag: string,
+  overwrite: boolean,
+  octokit: ReturnType<(typeof github)['getOctokit']>
+): Promise<undefined | string> {
+  const stat = fs.statSync(file)
+  if (!stat.isFile()) {
+    core.debug(`Skipping ${file}, since its not a file`)
+    return
+  }
+  const file_size = stat.size
+  const file_bytes: any = fs.createReadStream(file)
 
-    // Check for duplicates.
+  // Check for duplicates.
-    const assets = await octokit.repos.listAssetsForRelease({
+  const assets: RepoAssetsResp = await octokit.paginate(repoAssets, {
-        ...context.repo,
+    ...repo(),
-        release_id: release.data.id,
+    release_id: release.data.id
-    });
+  })
-    const duplicate_asset = assets.data.find(a => a.name === asset_name);
+  const duplicate_asset = assets.find(a => a.name === asset_name)
-    if (duplicate_asset !== undefined) {
+  if (duplicate_asset !== undefined) {
-        if (overwrite === "true") {
+    if (overwrite) {
-            core.debug(`An asset called ${asset_name} already exists in release ${tag} so we'll overwrite it.`)
+      core.debug(
-            await octokit.repos.deleteReleaseAsset({
+        `An asset called ${asset_name} already exists in release ${tag} so we'll overwrite it.`
-                ...context.repo,
+      )
-                asset_id: duplicate_asset.id
+      await octokit.request(deleteAssets, {
-            })
+        ...repo(),
-        } else {
+        asset_id: duplicate_asset.id
-            core.setFailed(`An asset called ${asset_name} already exists.`)
+      })
-            return;
-        }
     } else {
-        core.debug(`No pre-existing asset called ${asset_name} found in release ${tag}. All good.`);
+      core.setFailed(`An asset called ${asset_name} already exists.`)
+      return duplicate_asset.browser_download_url
     }
+  } else {
+    core.debug(
+      `No pre-existing asset called ${asset_name} found in release ${tag}. All good.`
+    )
+  }
 
-    core.debug(`Uploading ${file} to ${asset_name} in release ${tag}.`)
+  core.debug(`Uploading ${file} to ${asset_name} in release ${tag}.`)
-    await octokit.repos.uploadReleaseAsset({
+  const uploaded_asset: UploadAssetResp = await retry(
+    async () => {
+      return octokit.request(uploadAssets, {
+        ...repo(),
+        release_id: release.data.id,
         url: release.data.upload_url,
         name: asset_name,
-        file: file_bytes,
+        data: file_bytes,
         headers: {
-            "content-type": "binary/octet-stream",
+          'content-type': 'binary/octet-stream',
-            "content-length": file_size
+          'content-length': file_size
-        },
-    });
-}
-
-async function run() {
-    try {
-        const token = core.getInput('repo_token', { required: true });
-        const file = core.getInput('file', { required: true });
-        const asset_name = core.getInput('asset_name', { required: true });
-        const tag = core.getInput('tag', { required: true });
-        const overwrite = core.getInput('overwrite');
-
-        if (!fs.existsSync(file)) {
-            core.setFailed(`File ${file} wasn't found.`);
         }
-
+      })
-        const octokit = new github.GitHub(token);
+    },
-        const context = github.context;
+    {
-
+      maxAttempts: 3
-        const release = await get_release_by_tag(tag, octokit, context);
-        await upload_to_release(release, file, asset_name, tag, overwrite, octokit, context);
-    } catch (error) {
-        core.setFailed(error.message);
     }
+  )
+  return uploaded_asset.data.browser_download_url
 }
 
-run();
+function repo(): {owner: string; repo: string} {
+  const repo_name = core.getInput('repo_name')
+  // If we're not targeting a foreign repository, we can just return immediately and don't have to do extra work.
+  if (!repo_name) {
+    return github.context.repo
+  }
+  const owner = repo_name.substring(0, repo_name.indexOf('/'))
+  if (!owner) {
+    throw new Error(`Could not extract 'owner' from 'repo_name': ${repo_name}.`)
+  }
+  const repo_ = repo_name.substring(repo_name.indexOf('/') + 1)
+  if (!repo_) {
+    throw new Error(`Could not extract 'repo' from 'repo_name': ${repo_name}.`)
+  }
+  return {
+    owner,
+    repo: repo_
+  }
+}
+
+async function run(): Promise<void> {
+  try {
+    // Get the inputs from the workflow file: https://github.com/actions/toolkit/tree/master/packages/core#inputsoutputs
+    const token = core.getInput('repo_token', {required: true})
+    const file = core.getInput('file', {required: true})
+    const tag = core
+      .getInput('tag', {required: true})
+      .replace('refs/tags/', '')
+      .replace('refs/heads/', '')
+
+    const file_glob = core.getInput('file_glob') == 'true' ? true : false
+    const overwrite = core.getInput('overwrite') == 'true' ? true : false
+    const prerelease = core.getInput('prerelease') == 'true' ? true : false
+    const release_name = core.getInput('release_name')
+    const body = core
+      .getInput('body')
+      .replace(/%0A/gi, '\n')
+      .replace(/%0D/gi, '\r')
+      .replace(/%25/g, '%')
+
+    const octokit = github.getOctokit(token)
+    const release = await get_release_by_tag(
+      tag,
+      prerelease,
+      release_name,
+      body,
+      octokit
+    )
+
+    if (file_glob) {
+      const files = glob.sync(file)
+      if (files.length > 0) {
+        for (const file_ of files) {
+          const asset_name = path.basename(file_)
+          const asset_download_url = await upload_to_release(
+            release,
+            file_,
+            asset_name,
+            tag,
+            overwrite,
+            octokit
+          )
+          core.setOutput('browser_download_url', asset_download_url)
+        }
+      } else {
+        core.setFailed('No files matching the glob pattern found.')
+      }
+    } else {
+      const asset_name =
+        core.getInput('asset_name') !== ''
+          ? core.getInput('asset_name').replace(/\$tag/g, tag)
+          : path.basename(file)
+      const asset_download_url = await upload_to_release(
+        release,
+        file,
+        asset_name,
+        tag,
+        overwrite,
+        octokit
+      )
+      core.setOutput('browser_download_url', asset_download_url)
+    }
+  } catch (error: any) {
+    core.setFailed(error.message)
+  }
+}
+
+run()

tsconfig.json

@@ -1,63 +1,12 @@
 {
   "compilerOptions": {
-    /* Basic Options */
+    "target": "es6",
-    // "incremental": true,                   /* Enable incremental compilation */
+    "module": "commonjs",
-    "target": "es6",                          /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
+    "outDir": "./lib",
-    "module": "commonjs",                     /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
+    "rootDir": "./src",
-    // "allowJs": true,                       /* Allow javascript files to be compiled. */
+    "strict": true,
-    // "checkJs": true,                       /* Report errors in .js files. */
+    "noImplicitAny": true,
-    // "jsx": "preserve",                     /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
+    "esModuleInterop": true
-    // "declaration": true,                   /* Generates corresponding '.d.ts' file. */
-    // "declarationMap": true,                /* Generates a sourcemap for each corresponding '.d.ts' file. */
-    // "sourceMap": true,                     /* Generates corresponding '.map' file. */
-    // "outFile": "./",                       /* Concatenate and emit output to single file. */
-    "outDir": "./lib",                        /* Redirect output structure to the directory. */
-    "rootDir": "./src",                       /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
-    // "composite": true,                     /* Enable project compilation */
-    // "tsBuildInfoFile": "./",               /* Specify file to store incremental compilation information */
-    // "removeComments": true,                /* Do not emit comments to output. */
-    // "noEmit": true,                        /* Do not emit outputs. */
-    // "importHelpers": true,                 /* Import emit helpers from 'tslib'. */
-    // "downlevelIteration": true,            /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
-    // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
-
-    /* Strict Type-Checking Options */
-    "strict": true,                           /* Enable all strict type-checking options. */
-    "noImplicitAny": false,                 /* Raise error on expressions and declarations with an implied 'any' type. */
-    // "strictNullChecks": true,              /* Enable strict null checks. */
-    // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
-    // "strictBindCallApply": true,           /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
-    // "strictPropertyInitialization": true,  /* Enable strict checking of property initialization in classes. */
-    // "noImplicitThis": true,                /* Raise error on 'this' expressions with an implied 'any' type. */
-    // "alwaysStrict": true,                  /* Parse in strict mode and emit "use strict" for each source file. */
-
-    /* Additional Checks */
-    // "noUnusedLocals": true,                /* Report errors on unused locals. */
-    // "noUnusedParameters": true,            /* Report errors on unused parameters. */
-    // "noImplicitReturns": true,             /* Report error when not all code paths in function return a value. */
-    // "noFallthroughCasesInSwitch": true,    /* Report errors for fallthrough cases in switch statement. */
-
-    /* Module Resolution Options */
-    // "moduleResolution": "node",            /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
-    // "baseUrl": "./",                       /* Base directory to resolve non-absolute module names. */
-    // "paths": {},                           /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
-    // "rootDirs": [],                        /* List of root folders whose combined content represents the structure of the project at runtime. */
-    // "typeRoots": [],                       /* List of folders to include type definitions from. */
-    // "types": [],                           /* Type declaration files to be included in compilation. */
-    // "allowSyntheticDefaultImports": true,  /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
-    "esModuleInterop": true                   /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
-    // "preserveSymlinks": true,              /* Do not resolve the real path of symlinks. */
-    // "allowUmdGlobalAccess": true,          /* Allow accessing UMD globals from modules. */
-
-    /* Source Map Options */
-    // "sourceRoot": "",                      /* Specify the location where debugger should locate TypeScript files instead of source locations. */
-    // "mapRoot": "",                         /* Specify the location where debugger should locate map files instead of generated locations. */
-    // "inlineSourceMap": true,               /* Emit a single file with source maps instead of having a separate file. */
-    // "inlineSources": true,                 /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
-
-    /* Experimental Options */
-    // "experimentalDecorators": true,        /* Enables experimental support for ES7 decorators. */
-    // "emitDecoratorMetadata": true,         /* Enables experimental support for emitting type metadata for decorators. */
   },
   "exclude": ["node_modules", "**/*.test.ts"]
 }