Switch to Gradle Kotlin DSL #103

Closed
StckOverflw wants to merge 5 commits from master into master
Showing only changes of commit 03c4663a35 - Show all commits

View File

@ -63,32 +63,24 @@ tasks {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
} }
} }
java {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// Loom will automatically attach sourcesJar to a RemapSourcesJar task and to the "build" task
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// if it is present.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// If you remove this line, sources will not be generated.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
withSourcesJar()
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
jar { jar {
from("LICENSE") { from("LICENSE") {
rename { "${it}_${archives_base_name}" } rename { "${it}_${archives_base_name}" }
} }
} }
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val sourcesJar by creating(Jar::class) {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
dependsOn(JavaPlugin.CLASSES_TASK_NAME)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
archiveClassifier.convention("sources")
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
from(sourceSets["main"].allSource)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
} }
/*
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// configure the maven publication
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
publishing { publishing {
publications { publications {
mavenJava(MavenPublication) { create<MavenPublication>("maven") {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// add all the jars that should be included when publishing to maven // add all the jars that should be included when publishing to maven
artifact(remapJar) { artifact(remapJar.get())
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
dependsOn(remapJar) artifact(sourcesJar)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
artifact(sourcesJar) {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
dependsOn(remapSourcesJar)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
} }
} }
@ -100,4 +92,4 @@ publishing {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// retrieving dependencies. // retrieving dependencies.
} }
} }
*/ }
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```

DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```