Switch to Gradle Kotlin DSL #103

Closed
StckOverflw wants to merge 5 commits from master into master
3 changed files with 97 additions and 94 deletions

View File

@ -1,92 +0,0 @@
plugins {
id 'fabric-loom' version '0.7-SNAPSHOT'
id 'maven-publish'
}
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
archivesBaseName = project.archives_base_name
version = project.mod_version
group = project.maven_group
repositories {
// Add repositories to retrieve artifacts from in here.
// You should only use this when depending on other mods because
// Loom adds the essential maven repositories to download Minecraft and libraries from automatically.
// See https://docs.gradle.org/current/userguide/declaring_repositories.html
// for more information about repositories.
}
dependencies {
// To change the versions see the gradle.properties file
minecraft "com.mojang:minecraft:${project.minecraft_version}"
mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}"
// Fabric API. This is technically optional, but you probably want it anyway.
modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}"
// PSA: Some older mods, compiled on Loom 0.2.1, might have outdated Maven POMs.
// You may need to force-disable transitiveness on them.
}
processResources {
inputs.property "version", project.version
filesMatching("fabric.mod.json") {
expand "version": project.version
}
}
tasks.withType(JavaCompile).configureEach {
// ensure that the encoding is set to UTF-8, no matter what the system default is
// this fixes some edge cases with special characters not displaying correctly
// see http://yodaconditions.net/blog/fix-for-java-file-encoding-problems-with-gradle.html
// If Javadoc is generated, this must be specified in that task too.
it.options.encoding = "UTF-8"
// The Minecraft launcher currently installs Java 8 for users, so your mod probably wants to target Java 8 too
// JDK 9 introduced a new way of specifying this that will make sure no newer classes or methods are used.
// We'll use that if it's available, but otherwise we'll use the older option.
def targetVersion = 8
if (JavaVersion.current().isJava9Compatible()) {
it.options.release = targetVersion
}
}
java {
// Loom will automatically attach sourcesJar to a RemapSourcesJar task and to the "build" task
// if it is present.
// If you remove this line, sources will not be generated.
withSourcesJar()
}
jar {
from("LICENSE") {
rename { "${it}_${project.archivesBaseName}"}
}
}
// configure the maven publication
publishing {
publications {
mavenJava(MavenPublication) {
// add all the jars that should be included when publishing to maven
artifact(remapJar) {
builtBy remapJar
}
artifact(sourcesJar) {
builtBy remapSourcesJar
}
}
}
// See https://docs.gradle.org/current/userguide/publishing_maven.html for information on how to set up publishing.
repositories {
// Add repositories to publish to here.
// Notice: This block does NOT have the same function as the block in the top level.
// The repositories here will be used for publishing your artifact, not for
// retrieving dependencies.
}
}

95
build.gradle.kts Normal file
View File

@ -0,0 +1,95 @@
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
plugins {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
id("fabric-loom") version "0.7-SNAPSHOT"
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
`maven-publish`
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val sourceCompatibility = JavaVersion.VERSION_1_8
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val targetCompatibility = JavaVersion.VERSION_1_8
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val archives_base_name: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val mod_version: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val maven_group: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
liach commented 2021-06-03 01:20:11 +00:00 (Migrated from github.com)
Review

Why these? Are they no longer automatically polled from gradle.properties? Preferable if you poll from the properties in the {$} evaluation block.

Why these? Are they no longer automatically polled from `gradle.properties`? Preferable if you poll from the properties in the `{$}` evaluation block.
DRSchlaubi commented 2021-06-03 01:26:18 +00:00 (Migrated from github.com)
Review

Because that's not really possible in Kotlin hence the type safe part you need to explicitly declare your gradle.properties variables

Because that's not really possible in Kotlin hence the type safe part you need to explicitly declare your gradle.properties variables
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
repositories {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// Add repositories to retrieve artifacts from in here.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// You should only use this when depending on other mods because
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// Loom adds the essential maven repositories to download Minecraft and libraries from automatically.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// See https://docs.gradle.org/current/userguide/declaring_repositories.html
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// for more information about repositories.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val minecraft_version: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val yarn_mappings: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val loader_version: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val fabric_version: String by project
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
dependencies {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// To change the versions see the gradle.properties file
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
minecraft("com.mojang:minecraft:${minecraft_version}")
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
mappings("net.fabricmc:yarn:${yarn_mappings}:v2")
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
modImplementation("net.fabricmc:fabric-loader:${loader_version}")
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// Fabric API. This is technically optional, but you probably want it anyway.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
modImplementation("net.fabricmc.fabric-api:fabric-api:${fabric_version}")
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// PSA: Some older mods, compiled on Loom 0.2.1, might have outdated Maven POMs.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// You may need to force-disable transitiveness on them.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
tasks {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
withType<JavaCompile> {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// ensure that the encoding is set to UTF-8, no matter what the system default is
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// this fixes some edge cases with special characters not displaying correctly
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// see http://yodaconditions.net/blog/fix-for-java-file-encoding-problems-with-gradle.html
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// If Javadoc is generated, this must be specified in that task too.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
liach commented 2021-06-03 01:23:20 +00:00 (Migrated from github.com)
Review
Should just link to https://docs.gradle.org/current/dsl/org.gradle.api.tasks.compile.CompileOptions.html than some random blog
l4zs commented 2021-06-03 01:25:56 +00:00 (Migrated from github.com)
Review

this is same for the original

this is same for the original
DRSchlaubi commented 2021-06-03 01:27:25 +00:00 (Migrated from github.com)
Review

I guess he just copied the original but I agree the wall of text could be shortened down

I guess he just copied the original but I agree the wall of text could be shortened down
liach commented 2021-06-03 05:17:07 +00:00 (Migrated from github.com)
Review

But if you do carry out a big change like switching to kotlin, it's better to fix the overdue technical debt at the same time.

But if you do carry out a big change like switching to kotlin, it's better to fix the overdue technical debt at the same time.
options.encoding = "UTF-8"
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// The Minecraft launcher currently installs Java 8 for users, so your mod probably wants to target Java 8 too
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// JDK 9 introduced a new way of specifying this that will make sure no newer classes or methods are used.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// We'll use that if it's available, but otherwise we'll use the older option.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val targetVersion = 8
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
if (JavaVersion.current().isJava9Compatible) {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
options.release.convention(targetVersion)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
processResources {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
inputs.property("version", project.version)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
filesMatching("fabric.mod.json") {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
this.expand("version" to project.version)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
jar {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
from("LICENSE") {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
rename { "${it}_${archives_base_name}" }
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
val sourcesJar by creating(Jar::class) {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
dependsOn(classes)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
archiveClassifier.convention("sources")
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
from(sourceSets["main"].allSource)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
publishing {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
publications {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
create<MavenPublication>("maven") {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// add all the jars that should be included when publishing to maven
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
artifact(remapJar.get())
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
artifact(sourcesJar)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// See https://docs.gradle.org/current/userguide/publishing_maven.html for information on how to set up publishing.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
repositories {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// Add repositories to publish to here.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// Notice: This block does NOT have the same function as the block in the top level.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// The repositories here will be used for publishing your artifact, not for
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
// retrieving dependencies.
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```
}
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
		dependsOn(classes)
```suggestion dependsOn(classes) ```

View File

@ -1,8 +1,8 @@
pluginManagement {
repositories {
maven {
name = 'Fabric'
url = 'https://maven.fabricmc.net/'
name = "Fabric"
url = uri("https://maven.fabricmc.net/")
}
gradlePluginPortal()
}
DRSchlaubi commented 2021-06-03 01:08:52 +00:00 (Migrated from github.com)
Review
maven("https://maven.fabricmc.net/")
```suggestion maven("https://maven.fabricmc.net/") ```
liach commented 2021-06-03 01:24:10 +00:00 (Migrated from github.com)
Review

Still preferable to explicitly name this maven as "fabric"

Still preferable to explicitly name this maven as `"fabric"`