Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Switch to Gradle Kotlin DSL #103

Closed
StckOverflw wants to merge 5 commits from master into master
pull from: master
merge into: Steven:master
Conversation 16 Commits 5 Files Changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0b49d099d2 - Show all commits

2
build.gradle.kts
View File

@ -70,7 +70,7 @@ tasks {
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review
Copy Link

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review
Copy Link

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
Copy Link
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
Copy Link
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
Copy Link
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
Copy Link
		dependsOn(classes)
```suggestion dependsOn(classes) ```
} }
val sourcesJar by creating(Jar::class) { val sourcesJar by creating(Jar::class) {
dependsOn(JavaPlugin.CLASSES_TASK_NAME) dependsOn(classes)
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review
Copy Link

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
Copy Link
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
Copy Link
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review
Copy Link

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
Copy Link
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
Copy Link
		dependsOn(classes)
```suggestion dependsOn(classes) ```
archiveClassifier.convention("sources") archiveClassifier.convention("sources")
from(sourceSets["main"].allSource) from(sourceSets["main"].allSource)
} }

DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review
Copy Link

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:06:18 +00:00 (Migrated from github.com)
Review
Copy Link

use the built-in literal \maven-publish``

	`maven-publish`
use the built-in literal `\`maven-publish\`` ```suggestion `maven-publish` ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
Copy Link
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:07:56 +00:00 (Migrated from github.com)
Review
Copy Link
			this.expand("version" to project.version)
```suggestion this.expand("version" to project.version) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
Copy Link
		dependsOn(classes)
```suggestion dependsOn(classes) ```
DRSchlaubi commented 2021-06-03 01:08:17 +00:00 (Migrated from github.com)
Review
Copy Link
		dependsOn(classes)
```suggestion dependsOn(classes) ```