Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Add a clientside mod #114

Closed
rizet wants to merge 3 commits from 1.17 into 1.17
pull from: 1.17
merge into: Steven:1.17
Conversation 9 Commits 3 Files Changed 2 +26 -17
rizet commented 2021-07-03 23:42:16 +00:00 (Migrated from github.com)
Copy Link
No description provided.
modmuss50 (Migrated from github.com) requested changes 2021-07-03 23:59:28 +00:00
modmuss50 (Migrated from github.com) left a comment
Copy Link

This is quite dangerous. I would HIGHLY recommend creating a seprate class for client side code.

This is quite dangerous. I would HIGHLY recommend creating a seprate class for client side code.
OroArmor (Migrated from github.com) requested changes 2021-07-04 00:00:01 +00:00
OroArmor (Migrated from github.com) left a comment
Copy Link

Don't merge the client and general initialization into one class. This will cause more issues than helping people

Don't merge the client and general initialization into one class. This will cause more issues than helping people
frqnny commented 2021-07-04 00:07:24 +00:00 (Migrated from github.com)
Copy Link

Lol very bad idea. If you have a client sided field like an entity layer it would immediately crash on server start up

Lol very bad idea. If you have a client sided field like an entity layer it would immediately crash on server start up
rizet commented 2021-07-04 01:58:30 +00:00 (Migrated from github.com)
Copy Link

@modmuss50 I made the appropriate changes you requested.

@modmuss50 I made the appropriate changes you requested.
rizet commented 2021-07-07 20:11:46 +00:00 (Migrated from github.com)
Copy Link

When is this PR going to be reviewed again? It's been four days.

When is this PR going to be reviewed again? It's been four days.
frqnny (Migrated from github.com) approved these changes 2021-07-07 20:23:33 +00:00
frqnny (Migrated from github.com) left a comment
Copy Link

I think it’s good enough.

I think it’s good enough.
StoneLabs (Migrated from github.com) approved these changes 2021-08-07 23:12:14 +00:00
rizet commented 2021-08-10 05:40:47 +00:00 (Migrated from github.com)
Copy Link

@modmuss50 it's been a month. Would you like to review again?

@modmuss50 it's been a month. Would you like to review again?
rizet commented 2021-08-28 12:32:36 +00:00 (Migrated from github.com)
Copy Link

my g this is kinda dead now i'll just close it

my g this is kinda dead now i'll just close it

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
modmuss50
OroArmor
frqnny
StoneLabs
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Steven
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#114
Delete Branch "1.17"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?