Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Add mojmap option #62

Closed
Earthcomputer wants to merge 2 commits from patch-2 into master
pull from: patch-2
merge into: Steven:master
Conversation 6 Commits 2 Files Changed 1 +3 -1
Earthcomputer commented 2020-08-25 07:14:45 +00:00 (Migrated from github.com)
Copy Link

Don't merge until loom 0.5 is stable, of course :)

Don't merge until loom 0.5 is stable, of course :)
👍 5
modmuss50 commented 2020-08-25 07:52:44 +00:00 (Migrated from github.com)
Copy Link

No. I don’t think we want this. Yarn is still the default and is still the only officially supported mappings. The mojang mappings aren’t something I think we should be advertising like this.

No. I don’t think we want this. Yarn is still the default and is still the only officially supported mappings. The mojang mappings aren’t something I think we should be advertising like this.
Earthcomputer commented 2020-08-25 07:56:13 +00:00 (Migrated from github.com)
Copy Link

You still haven't been open as to why you have made that decision. Let's wait for others' opinions on this as well.

You still haven't been open as to why you have made that decision. Let's wait for others' opinions on this as well.
modmuss50 commented 2020-08-25 08:17:18 +00:00 (Migrated from github.com)
Copy Link

I think I’ve been open about it. Yarn IMO provides a superior experience with better names, params and documentation. The license on the mappings is still up for debate but it’s beyond me so I’ll let the people who know what they are talking about deal with that.

I’d like to hope yarn will continue on, but this will only happen if people continue to contribute to it. Right now the discussion of the mojang names is also disallowed (To protect yarn) making it hard for people to get help with these names.

I think I’ve been open about it. Yarn IMO provides a superior experience with better names, params and documentation. The license on the mappings is still up for debate but it’s beyond me so I’ll let the people who know what they are talking about deal with that. I’d like to hope yarn will continue on, but this will only happen if people continue to contribute to it. Right now the discussion of the mojang names is also disallowed (To protect yarn) making it hard for people to get help with these names.
👍 4
modmuss50 (Migrated from github.com) reviewed 2020-08-25 15:13:36 +00:00
build.gradle
modmuss50 (Migrated from github.com) commented 2020-08-25 15:13:36 +00:00
Copy Link

This isnt how its done either

This isnt how its done either
modmuss50 (Migrated from github.com) reviewed 2020-08-25 15:14:10 +00:00
build.gradle
modmuss50 (Migrated from github.com) commented 2020-08-25 15:14:10 +00:00
Copy Link

mappings minecraft.officialMojangMappings()

`mappings minecraft.officialMojangMappings()`
Earthcomputer (Migrated from github.com) reviewed 2020-08-25 15:20:26 +00:00
build.gradle
Earthcomputer (Migrated from github.com) commented 2020-08-25 15:20:26 +00:00
Copy Link

Fixed

Fixed

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
modmuss50
Earthcomputer
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Steven
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#62
Delete Branch "patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?