Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Configadd #82

Closed
yakyakyakyak wants to merge 4 commits from Configadd into master
pull from: Configadd
merge into: Steven:master
Conversation 3 Commits 4 Files Changed 6 +11 -132
yakyakyakyak commented 2021-02-07 10:45:27 +00:00 (Migrated from github.com)
Copy Link

Added config, minor structure additions

Added config, minor structure additions
YTG1234 (Migrated from github.com) requested changes 2021-02-07 10:50:53 +00:00
YTG1234 (Migrated from github.com) left a comment
Copy Link

Do not delete the license and readme files. What are you thinking?

The example mod and Mixin files are also important.

Do not delete the license and readme files. What are you thinking? The example mod and Mixin files are also important.
gradle.properties
@@ -14,2 +12,4 @@
maven_group = com.refsonyak.endgameaddons
archives_base_name = endgame-addons-mod
# Dependencies
YTG1234 (Migrated from github.com) commented 2021-02-07 10:47:02 +00:00
Copy Link

Absolutely not.

Absolutely not.
src/main/java/net/refsonyak/endgameaddons/Config.java
@@ -0,0 +1,9 @@
public class Config {
/*Class that contains all configurable variables for quick'n'easy balance changes
YTG1234 (Migrated from github.com) commented 2021-02-07 10:47:46 +00:00
Copy Link

Please word more carefully and format the comment to either use // or have /* and */ on a separate line.

Please word more carefully and format the comment to either use `//` or have `/*` and `*/` on a separate line.
src/main/java/net/refsonyak/endgameaddons/Config.java
@@ -0,0 +3,4 @@
To use, simply create a class in here, give it some variables, import it into your
file. Call on it using Config.<yourclass>.<yourvariable> and voila!*/
public class dropRates {
YTG1234 (Migrated from github.com) commented 2021-02-07 10:50:42 +00:00
Copy Link

This is horrible naming conventions and classes should be static. You also do not need inner classes for everything. Static fields should be enough. Please also provide information about de/serialization and configuration screens.

This is horrible naming conventions and classes should be `static`. You also do not need inner classes for everything. Static fields should be enough. Please also provide information about de/serialization and configuration screens.
Juuxel commented 2021-02-07 10:51:52 +00:00 (Migrated from github.com)
Copy Link

@YTG1234 I'm pretty sure this PR isn't supposed to be here. (See #80 which was closed.)

@YTG1234 I'm pretty sure this PR isn't supposed to be here. (See #80 which was closed.)
yakyakyakyak commented 2021-02-07 10:51:53 +00:00 (Migrated from github.com)
Copy Link

hi i fked up, thought this was my fork. sorry i'm garbage

hi i fked up, thought this was my fork. sorry i'm garbage

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
YTG1234
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Steven
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#82
Delete Branch "Configadd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?