Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Remove unnecessary GitHub Actions step #93

Closed
davidbailey00 wants to merge 1 commits from remove-unnecessary-chmod-x into master
pull from: remove-unnecessary-chmod-x
merge into: Steven:master
Conversation 3 Commits 1 Files Changed 1 -3
davidbailey00 commented 2021-03-27 16:36:05 +00:00 (Migrated from github.com)
Copy Link

"make gradle wrapper executable" is unnecessary because the file already has the executable bit set in the repository.

"make gradle wrapper executable" is unnecessary because the file already has the executable bit set in the repository.
ByMartrixx commented 2021-03-27 16:46:48 +00:00 (Migrated from github.com)
Copy Link

PR #71, where this was added
https://github.com/FabricMC/fabric-example-mod/pull/71/files#r516437188

PR #71, where this was added https://github.com/FabricMC/fabric-example-mod/pull/71/files#r516437188
davidbailey00 commented 2021-03-27 16:50:47 +00:00 (Migrated from github.com)
Copy Link

@ByMartrixx Thanks, didn't spot that but I now see why this was kept :)

That said, I would ask, isn't the point of CI to spot mistakes like that? To me it seems better if CI fails and prevents someone from accidentally removing the x bit so that it can be fixed before a PR is merged, rather than the problem being passed down to people using this template who might not know what's wrong if they're unfamiliar with Unix permissions.

@ByMartrixx Thanks, didn't spot that but I now see why this was kept :) That said, I would ask, isn't the point of CI to spot mistakes like that? To me it seems better if CI fails and prevents someone from accidentally removing the `x` bit so that it can be fixed before a PR is merged, rather than the problem being passed down to people using this template who might not know what's wrong if they're unfamiliar with Unix permissions.
modmuss50 commented 2021-03-27 20:05:01 +00:00 (Migrated from github.com)
Copy Link

No, like ByMartrixx pointed out this is fine as-is. On windows it can be a PITA to set that flag so CI builds.

Thanks anyway.

No, like ByMartrixx pointed out this is fine as-is. On windows it can be a PITA to set that flag so CI builds. Thanks anyway.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Steven
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#93
Delete Branch "remove-unnecessary-chmod-x"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?