Steven/fabric-example-mod
1
0
Fork 0
Code Issues 38 Pull Requests 2 Projects Releases Wiki Activity

Update Gradle to 7.0, Bump CI stuff #95

Merged
actuallyasmartname merged 8 commits from master into master 2021-05-15 10:29:26 +00:00
Conversation 8 Commits 8 Files Changed 5 +99 -98
actuallyasmartname commented 2021-04-14 14:38:57 +00:00 (Migrated from github.com)
Copy Link

(ignore the Merge Pull Request Commit)

(ignore the Merge Pull Request Commit)
modmuss50 (Migrated from github.com) requested changes 2021-04-14 14:57:50 +00:00
.github/workflows/build.yml
modmuss50 (Migrated from github.com) commented 2021-04-14 14:56:08 +00:00
Copy Link

I think I would prefer adopt here

I think I would prefer adopt here
gradle.properties
modmuss50 (Migrated from github.com) commented 2021-04-14 14:56:42 +00:00
Copy Link

No, I would leave this be until a propper solution is sorted.

No, I would leave this be until a propper solution is sorted.
gradle/wrapper/gradle-wrapper.properties
modmuss50 (Migrated from github.com) commented 2021-04-14 14:57:02 +00:00
Copy Link

This also needs loom 0.7

This also needs loom 0.7
actuallyasmartname (Migrated from github.com) reviewed 2021-04-14 16:33:56 +00:00
.github/workflows/build.yml
actuallyasmartname (Migrated from github.com) commented 2021-04-14 16:33:56 +00:00
Copy Link

Alright.

Alright.
modmuss50 (Migrated from github.com) approved these changes 2021-04-14 20:00:22 +00:00
modmuss50 (Migrated from github.com) left a comment
Copy Link

Changes look good, I will hold onto this for a little while as 0.7 loom is still in beta.

Thanks 👍

Changes look good, I will hold onto this for a little while as 0.7 loom is still in beta. Thanks 👍
actuallyasmartname commented 2021-04-20 15:02:55 +00:00 (Migrated from github.com)
Copy Link

Since https://modmuss50.me/fabric.html now redirects to https://fabricmc.net/versions.html, is it ok to change it to the fabric counterpart?

Since https://modmuss50.me/fabric.html now redirects to https://fabricmc.net/versions.html, is it ok to change it to the fabric counterpart?
sfPlayer1 commented 2021-04-20 15:08:11 +00:00 (Migrated from github.com)
Copy Link

Yes please, it's still only a makeshift thing but a bit more integrated

Yes please, it's still only a makeshift thing but a bit more integrated
👍 1
sfPlayer1 (Migrated from github.com) approved these changes 2021-04-21 11:21:39 +00:00
sfPlayer1 (Migrated from github.com) left a comment
Copy Link

LGTM, thanks!

LGTM, thanks!
modmuss50 (Migrated from github.com) approved these changes 2021-05-12 15:42:39 +00:00
modmuss50 (Migrated from github.com) left a comment
Copy Link

0.7 is as stable as its going to get, so this is great 👍

0.7 is as stable as its going to get, so this is great 👍
NoComment1105 commented 2021-05-12 15:44:27 +00:00 (Migrated from github.com)
Copy Link

0.7 is as stable as its going to get, so this is great 👍

Gradle 7.0.1 was release a few hours ago, i believe many bugs were fixed, should this change to gradle 7.0.1 too?

> 0.7 is as stable as its going to get, so this is great 👍 Gradle 7.0.1 was release a few hours ago, i believe many bugs were fixed, should this change to gradle 7.0.1 too?
👍 2
modmuss50 commented 2021-05-12 15:44:46 +00:00 (Migrated from github.com)
Copy Link

Yeah, might as well 👍

Yeah, might as well 👍
👍 1
actuallyasmartname commented 2021-05-14 13:30:55 +00:00 (Migrated from github.com)
Copy Link

Gonna update to 7.0.1 in a bit

Gonna update to 7.0.1 in a bit
modmuss50 commented 2021-05-14 13:36:49 +00:00 (Migrated from github.com)
Copy Link

Heads up that 7.0.2 just came out :)

Heads up that 7.0.2 just came out :)
👍 1
actuallyasmartname commented 2021-05-14 13:55:06 +00:00 (Migrated from github.com)
Copy Link

Just realized it when I saw it on the Gradle releases page, but thank you!

Just realized it when I saw it on the Gradle releases page, but thank you!
actuallyasmartname commented 2021-05-14 14:01:02 +00:00 (Migrated from github.com)
Copy Link

Should be ready to merge

Should be ready to merge
modmuss50 (Migrated from github.com) approved these changes 2021-05-14 14:21:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sfPlayer1
modmuss50
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Steven/fabric-example-mod#95
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?